Prefix URLs in CSS templates #972

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@fab-b
Contributor

fab-b commented Feb 7, 2014

This commit introduces the possibility to define a method to be used to prefix all the image urls inside css templates.

fab-b added a commit to fab-b/ariatemplates that referenced this pull request Feb 7, 2014

feat #972 prefix URLs in CSS templates
This commit introduces the possibility to define a method to be used to prefix all the image urls inside css templates.
@benouat

This comment has been minimized.

Show comment
Hide comment
@benouat

benouat Feb 10, 2014

Member

How to do you manage the fact that people might need to define multiple prefixing mechanism ?

In your implementation imgUrlMapping is a single method. My concern here, is that it might be useful to be able to register multiple different imgUrlMapping.

This might be handy in applications that might be composed from pieces produced by different teams (each one might want to deal with its own method).

Appart from this consideration, I am fine with the single implementation

Member

benouat commented Feb 10, 2014

How to do you manage the fact that people might need to define multiple prefixing mechanism ?

In your implementation imgUrlMapping is a single method. My concern here, is that it might be useful to be able to register multiple different imgUrlMapping.

This might be handy in applications that might be composed from pieces produced by different teams (each one might want to deal with its own method).

Appart from this consideration, I am fine with the single implementation

feat #972 prefix URLs in CSS templates
This commit introduces the possibility to define a method to be used to prefix all the image urls inside css templates.

fab-b added a commit that referenced this pull request Feb 10, 2014

feat #972 prefix URLs in CSS templates
This commit introduces the possibility to define a method to be used to prefix all the image urls inside css templates.
@fab-b

This comment has been minimized.

Show comment
Hide comment
@fab-b

fab-b Feb 10, 2014

Contributor
Contributor

fab-b commented Feb 10, 2014

@fab-b fab-b closed this Feb 10, 2014

@flongo flongo added this to the 1.4.16 milestone Feb 13, 2014

carlo-mr added a commit to carlo-mr/ariatemplates that referenced this pull request Mar 3, 2014

feat #972 prefix URLs in CSS templates
This commit introduces the possibility to define a method to be used to prefix all the image urls inside css templates.

@fab-b fab-b deleted the fab-b:css_prefix branch Mar 7, 2014

jakub-g added a commit to jakub-g/ariatemplates that referenced this pull request May 4, 2015

fix #1468 Prefix URLs in CSS templates feature not working
Feature implemented in #972 did not work due to invalid CSS
generated: a space between `url` keyword and the parentheses
made the whole CSS rule invalid and hence not applied

jakub-g added a commit to jakub-g/ariatemplates that referenced this pull request May 4, 2015

fix #1468 Prefix URLs in CSS templates feature not working
Feature implemented in #972 did not work due to invalid CSS
generated: a space between `url` keyword and the parentheses
made the whole CSS rule invalid and hence not applied

jakub-g added a commit to jakub-g/ariatemplates that referenced this pull request May 5, 2015

fix #1468 Prefix URLs in CSS templates feature not working
Feature implemented in #972 did not work due to invalid CSS
generated: a space between `url` keyword and the parentheses
made the whole CSS rule invalid and hence not applied

jakub-g added a commit to jakub-g/ariatemplates that referenced this pull request May 5, 2015

fix #1468 Prefix URLs in CSS templates feature not working
Feature implemented in #972 did not work due to invalid CSS
generated: a space between `url` keyword and the parentheses
made the whole CSS rule invalid and hence not applied

jakub-g added a commit that referenced this pull request May 5, 2015

fix #1468 Prefix URLs in CSS templates feature not working
Feature implemented in #972 did not work due to invalid CSS
generated: a space between `url` keyword and the parentheses
made the whole CSS rule invalid and hence not applied

(cherry picked from commit 8d38b0d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment