docs: Precompiled, packaged & minified version #242

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@benouat
Owner

benouat commented Jul 16, 2014

This PR updates the playground build to be precompiled (hsp, and js
transpiled) packaged and minified.

The goal is to optimize the initial display of the playground.

@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Jul 16, 2014

Coverage Status

Coverage remained the same when pulling d1f1e14 on benouat:precompiled-playground into f824098 on ariatemplates:master.

Coverage Status

Coverage remained the same when pulling d1f1e14 on benouat:precompiled-playground into f824098 on ariatemplates:master.

@b-laporte

This comment has been minimized.

Show comment Hide comment
@b-laporte

b-laporte Jul 16, 2014

Owner

Can you please check that compilation errors are properly displayed as this is broken in the latest playground version (!) Thx

Owner

b-laporte commented Jul 16, 2014

Can you please check that compilation errors are properly displayed as this is broken in the latest playground version (!) Thx

@benouat

This comment has been minimized.

Show comment Hide comment
@benouat

benouat Jul 16, 2014

Owner

Ok, I'll double check, but it should be working again 😄

compile_error

Owner

benouat commented Jul 16, 2014

Ok, I'll double check, but it should be working again 😄

compile_error

@divdavem divdavem self-assigned this Jul 16, 2014

@benouat

This comment has been minimized.

Show comment Hide comment
@benouat

benouat Jul 16, 2014

Owner

@divdavem could you have a look at it for review ?

Owner

benouat commented Jul 16, 2014

@divdavem could you have a look at it for review ?

docs/playground/playground.js
+ var spl = self.data.samples[self.data.sampleIndex];
+
+ // reading from the cache what the executed module is exporting
+ spl.sample = require.cache[moduleName].exports;

This comment has been minimized.

Show comment Hide comment
@divdavem

divdavem Jul 16, 2014

Member

noder.execute returns the exports object, so it shoud be sufficient to do:

noder.execute(code, moduleName).then(function (sampleExports) {
   var spl = self.data.samples[self.data.sampleIndex];
   spl.sample = sampleExports;
   // ...
}, /* ... */).end();
@divdavem

divdavem Jul 16, 2014

Member

noder.execute returns the exports object, so it shoud be sufficient to do:

noder.execute(code, moduleName).then(function (sampleExports) {
   var spl = self.data.samples[self.data.sampleIndex];
   spl.sample = sampleExports;
   // ...
}, /* ... */).end();

This comment has been minimized.

Show comment Hide comment
@benouat

benouat Jul 17, 2014

Owner

Good to know !!! 😃 I'll update it

@benouat

benouat Jul 17, 2014

Owner

Good to know !!! 😃 I'll update it

@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Jul 17, 2014

Coverage Status

Coverage remained the same when pulling 396a5fe on benouat:precompiled-playground into b3ed244 on ariatemplates:master.

Coverage Status

Coverage remained the same when pulling 396a5fe on benouat:precompiled-playground into b3ed244 on ariatemplates:master.

docs: Precompiled, packaged & minified version
This PR updates the playground build to be precompiled (hsp, and js
transpiled) packaged and minified.

The goal is to optimize the initial display of the playground.
@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Jul 17, 2014

Coverage Status

Coverage remained the same when pulling a78257e on benouat:precompiled-playground into b3ed244 on ariatemplates:master.

Coverage Status

Coverage remained the same when pulling a78257e on benouat:precompiled-playground into b3ed244 on ariatemplates:master.

@benouat benouat closed this in 452815d Jul 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment