Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reducing the size of noder by replacing some constants by their value.
- Loading branch information
Showing
5 changed files
with
201 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /* | ||
| * Copyright 2013 Amadeus s.a.s. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| var UglifyJS = require("uglify-js"); | ||
|
|
||
| var copyToken = function(token) { | ||
| token = token || {}; | ||
| return new UglifyJS.AST_Token({ | ||
| comments_before: (token.comments_before || []).slice(0) | ||
| }); | ||
| }; | ||
|
|
||
| module.exports = function(node) { | ||
| var transformer = new UglifyJS.TreeTransformer(function(node, descend) { | ||
| var nodeClone = node.clone(); | ||
| nodeClone.start = copyToken(node.start); | ||
| nodeClone.end = copyToken(node.end); | ||
| descend(nodeClone, this); | ||
| return nodeClone; | ||
| }); | ||
| return node.transform(transformer); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| /* | ||
| * Copyright 2013 Amadeus s.a.s. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| var UglifyJS = require("uglify-js"); | ||
| var replaceNode = require("./replaceNode"); | ||
| var cloneNode = require("./cloneNode"); | ||
|
|
||
| var constantTypes = [UglifyJS.AST_Number, UglifyJS.AST_String, UglifyJS.AST_Boolean]; | ||
| var isAcceptedConstantType = function(node) { | ||
| return constantTypes.some(function(type) { | ||
| return node instanceof type; | ||
| }); | ||
| }; | ||
|
|
||
| module.exports = function(ast) { | ||
| var extraInfoNodeName = "replaceConstantsInfo" + (new Date()).getTime(); | ||
| var symbols = []; | ||
| var walker = new UglifyJS.TreeWalker(function(node) { | ||
| if (node instanceof UglifyJS.AST_Symbol && node.thedef) { | ||
| var thedef = node.thedef; | ||
| var extraInfo = thedef[extraInfoNodeName]; | ||
| if (!extraInfo) { | ||
| thedef[extraInfoNodeName] = extraInfo = { | ||
| name: thedef.name, | ||
| constant: true, // will be changed to false if the variable is assigned a value | ||
| usages: [] | ||
| }; | ||
| symbols.push(extraInfo); | ||
| } | ||
| var parent = walker.parent(); | ||
| if ((parent instanceof UglifyJS.AST_Assign && parent.left === node) || parent instanceof UglifyJS.AST_Unary) { | ||
| extraInfo.constant = false; | ||
| } | ||
| if (parent instanceof UglifyJS.AST_VarDef && parent.name === node) { | ||
| if (extraInfo.definition) { | ||
| // 2 different definitions | ||
| extraInfo.constant = false; | ||
| } | ||
| extraInfo.definition = { | ||
| varDef: parent, | ||
| varList: walker.parent(1), | ||
| varListParent: walker.parent(2) | ||
| }; | ||
| extraInfo.value = parent.value; | ||
| } else { | ||
| extraInfo.usages.push({ | ||
| node: node, | ||
| parent: parent | ||
| }); | ||
| } | ||
| } | ||
| }); | ||
| ast.walk(walker); | ||
| symbols.forEach(function(extraInfo) { | ||
| if (extraInfo.constant && isAcceptedConstantType(extraInfo.value)) { | ||
| var originalNode = extraInfo.value; | ||
| originalNode.start = new UglifyJS.AST_Token({ | ||
| comments_before: [{ | ||
| type: "comment2", | ||
| value: extraInfo.name | ||
| } | ||
| ] | ||
| }); | ||
| extraInfo.usages.forEach(function(usage) { | ||
| var newNode = cloneNode(extraInfo.value); | ||
| replaceNode(usage.node, usage.parent, newNode); | ||
| }); | ||
| if (extraInfo.definition.varList.definitions.length > 1) { | ||
| replaceNode(extraInfo.definition.varDef, extraInfo.definition.varList, null); | ||
| } else { | ||
| replaceNode(extraInfo.definition.varList, extraInfo.definition.varListParent, null); | ||
| } | ||
| } | ||
| }); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| /* | ||
| * Copyright 2013 Amadeus s.a.s. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| // This file contains a utility method to replace a node by another in an UglifyJS2 AST. | ||
|
|
||
| var replaceNodeInArray = function(array, oldNode, newNode) { | ||
| for (var i = 0, l = array.length; i < l; i++) { | ||
| if (array[i] === oldNode) { | ||
| if (newNode) { | ||
| array[i] = newNode; | ||
| } else { | ||
| array.splice(i, 1); | ||
| } | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| }; | ||
|
|
||
| var replaceNodeInProperties = function(parent, oldNode, newNode) { | ||
| var properties = parent.CTOR.PROPS; | ||
| for (var i = 0, l = properties.length; i < l; i++) { | ||
| var curProperty = properties[i]; | ||
| var curValue = parent[curProperty]; | ||
| if (curValue === oldNode) { | ||
| if (newNode) { | ||
| parent[curProperty] = newNode; | ||
| } else { | ||
| delete parent[curProperty]; | ||
| } | ||
| return true; | ||
| } else if (Array.isArray(curValue)) { | ||
| if (replaceNodeInArray(curValue, oldNode, newNode)) { | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
| return false; | ||
| }; | ||
|
|
||
| module.exports = function(node, parent, newNode) { | ||
| if (newNode && !newNode.start) { | ||
| // this is needed because of a bug in uglify-js if start is not defined on some specific nodes | ||
| newNode.start = { | ||
| comments_before: [] | ||
| }; | ||
| } | ||
| if (replaceNodeInProperties(parent, node, newNode)) { | ||
| return; | ||
| } | ||
| throw new Error("Internal error: unable to find the node to replace"); | ||
| }; |