Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #113

wants to merge 6 commits into
base: master

Various fixes #113

wants to merge 6 commits into from


Copy link

@xaviershay xaviershay commented Dec 22, 2017

Fix for #111

Before (with inspection time 20s):
screen shot 2017-12-22 at 1 48 00 pm

screen shot 2017-12-22 at 1 31 57 pm

Fix for #108

Pretty straightforward I think? I think this covers the only two ways to exit the timer: inspection expiry and standard finish.

Added "Use scramble" feature for #97

screen shot 2017-12-22 at 3 56 20 pm

I'm not really familiar with common Android architecture (intents/broadcasts/etc) but this seemed a rather neat way to do it. Feedback welcome.

Fix for #97

The history setting was being stored in an instance variable when changed, but not persisted back to the fragment arguments that are used when fragment is recreated (as happens in a rotation).

Before merging:

  • Need to confirm translations are done properly. Opened #112 to better document once correct procedure is learned.
  • Apply the build file updates separately. Kept here so that I can actually build the PR, but should be applied separately to master.
  • (optional) Use string needs translations.
xaviershay added 4 commits Dec 22, 2017
These were all suggested by build failures and warnings.
This is more consistent with standard presentation of settings. There's
no need to call out the default value explicitly here – the default
button in the dialog reveals it if needed. Instead, show the current
value of the setting.
These are generated files, but I'm not sure how they are generated and
wanted to ensure the build didn't crash in the meantime. Opened #112 to
better document.
@xaviershay xaviershay force-pushed the xaviershay:xavier-dev branch from f28c3c3 to da20e47 Dec 22, 2017
@xaviershay xaviershay changed the title Inspection time fix Various fixes Dec 22, 2017
xaviershay added 2 commits Dec 22, 2017
This adds a new menu item to the overflow button on the time dialog
(from clicking on a solve in history) that switches to the main timer
with that solve's scramble loaded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.