Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP


Hi Ariejan, just fixed a little bug. #45

wants to merge 1 commit into from

3 participants


No description provided.


Hey @onland

Thanks, but what bug did you fix?


@onland would be really nice if you add a test to reproduce the bug in the old code and assert that the new code works.


@onland @douglascamata this is a private method, if it's broken (e.g. it throws a fatal error), I'd expect any of the specs for the public methods that use this private method to raise and error (or give unexpected results).

See for details.

If anything, we'd need a spec in that checks if the specified URL is correct.


Ah, you're using ruby 1.8.7.

ruby-2.0.0 is the current stable and ruby-1.9.3 is the previous release available on

For that reason support for ruby-1.8.x was dropped. Also see #40.

@ariejan ariejan closed this

@onland I've added ree and 1.8.7 to the travis build (although they both fail). If you could get specs to pass for 1.8.7 / ree I'd be happy to pull in the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 19, 2013
  1. @onland


    onland authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 2 deletions.
  1. +1 −2  lib/imdb/serie.rb
3  lib/imdb/serie.rb
@@ -14,8 +14,7 @@ def seasons
def season_urls
-"h5[text()='Seasons:'] ~ div a[@href*='episodes?season']")
- .map { |link| url.gsub("combined","") + "episodes?season=" + link.content.strip } rescue []
+"h5[text()='Seasons:'] ~ div a[@href*='episodes?season']").map { |link| url.gsub("combined","") + "episodes?season=" + link.content.strip } rescue []
end # Serie
Something went wrong with that request. Please try again.