Hi Ariejan, just fixed a little bug. #45

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@onland
onland commented Mar 19, 2013

No description provided.

@ariejan
Owner
ariejan commented Mar 19, 2013

Hey @onland

Thanks, but what bug did you fix?

@onland
onland commented Mar 20, 2013

Hi ArieJan,
There was a newline in series.rb:18 that caused a fatal error.

Vriendelijke groet,

Sander Onland

Op 19 mrt. 2013 om 22:07 heeft Ariejan de Vroom notifications@github.com het volgende geschreven:

Hey @onland

Thanks, but what bug did you fix?


Reply to this email directly or view it on GitHub.

@douglascamata

@onland would be really nice if you add a test to reproduce the bug in the old code and assert that the new code works.

@ariejan
Owner
ariejan commented Mar 20, 2013

@onland @douglascamata this is a private method, if it's broken (e.g. it throws a fatal error), I'd expect any of the specs for the public methods that use this private method to raise and error (or give unexpected results).

See https://github.com/ariejan/imdb/blob/master/spec/imdb/series_spec.rb for details.

If anything, we'd need a spec in https://github.com/ariejan/imdb/blob/master/spec/imdb/season_spec.rb that checks if the specified URL is correct.

@onland
onland commented Mar 20, 2013

Hi Ariejan & Douglas,

How about this:

[09:50:31]sander@silverbook:~/Sites/rails/filmladder/engine # On branch rails-3-2 18 files 104 $>rails c
/Users/sander/.rvm/gems/ruby-1.8.7-p358@filmladder/gems/imdb-0.7.0/lib/imdb.rb:10:in require': /Users/sander/.rvm/gems/ruby-1.8.7-p358@filmladder/gems/imdb-0.7.0/lib/imdb/serie.rb:18: syntax error, unexpected '.', expecting kEND (SyntaxError) .map { |link| url.gsub("combine... ^ from /Users/sander/.rvm/gems/ruby-1.8.7-p358@filmladder/gems/imdb-0.7.0/lib/imdb.rb:10 from /Users/sander/.rvm/gems/ruby-1.8.7-p358@filmladder/gems/bundler-1.1.3/lib/bundler/runtime.rb:68:inrequire'
from /Users/sander/.rvm/gems/ruby-1.8.7-p358@filmladder/gems/bundler-1.1.3/lib/bundler/runtime.rb:68:in require' from /Users/sander/.rvm/gems/ruby-1.8.7-p358@filmladder/gems/bundler-1.1.3/lib/bundler/runtime.rb:66:ineach'
from /Users/sander/.rvm/gems/ruby-1.8.7-p358@filmladder/gems/bundler-1.1.3/lib/bundler/runtime.rb:66:in require' from /Users/sander/.rvm/gems/ruby-1.8.7-p358@filmladder/gems/bundler-1.1.3/lib/bundler/runtime.rb:55:ineach'
from /Users/sander/.rvm/gems/ruby-1.8.7-p358@filmladder/gems/bundler-1.1.3/lib/bundler/runtime.rb:55:in require' from /Users/sander/.rvm/gems/ruby-1.8.7-p358@filmladder/gems/bundler-1.1.3/lib/bundler.rb:119:inrequire'
from /Users/sander/Sites/rails/filmladder/engine/config/application.rb:7
from /Users/sander/.rvm/gems/ruby-1.8.7-p358@filmladder/gems/railties-3.2.13/lib/rails/commands.rb:39:in require' from /Users/sander/.rvm/gems/ruby-1.8.7-p358@filmladder/gems/railties-3.2.13/lib/rails/commands.rb:39 from script/rails:9:inrequire'
from script/rails:9

I don't have a clue how to put this into a spec-file.

Kind regards,

Sander

On 20 Mar 2013, at 9:28, Ariejan de Vroom wrote:

@onland @douglascamata this is a private method, if it's broken (e.g. it throws a fatal error), I'd expect any of the specs for the public methods that use this private method to raise and error (or give unexpected results).

See https://github.com/ariejan/imdb/blob/master/spec/imdb/series_spec.rb for details.

If anything, we'd need a spec in https://github.com/ariejan/imdb/blob/master/spec/imdb/season_spec.rb that checks if the specified URL is correct.


Reply to this email directly or view it on GitHub.

@ariejan
Owner
ariejan commented Mar 20, 2013

Ah, you're using ruby 1.8.7.

ruby-2.0.0 is the current stable and ruby-1.9.3 is the previous release available on http://www.ruby-lang.org/en/downloads/

For that reason support for ruby-1.8.x was dropped. Also see #40.

@ariejan ariejan closed this Mar 20, 2013
@onland
onland commented Mar 20, 2013

Ok, that explains everything.

Well, thats a pity, I'm still running ree on production.

Thanks anyway for the excellent gem.

Groet,

Sander

On 20 Mar 2013, at 10:48, Ariejan de Vroom wrote:

Ah, you're using ruby 1.8.7.

ruby-2.0.0 is the current stable and ruby-1.9.3 is the previous release available on http://www.ruby-lang.org/en/downloads/

For that reason support for ruby-1.8.x was dropped. Also see #40.


Reply to this email directly or view it on GitHub.

@ariejan
Owner
ariejan commented Mar 20, 2013

@onland I've added ree and 1.8.7 to the travis build (although they both fail). If you could get specs to pass for 1.8.7 / ree I'd be happy to pull in the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment