Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Non-existent profiles are ignored without errors #3930

Closed
1 task done
pmprado opened this issue May 1, 2024 · 4 comments · Fixed by #4516
Closed
1 task done

Feat(eos_designs): Non-existent profiles are ignored without errors #3930

pmprado opened this issue May 1, 2024 · 4 comments · Fixed by #4516
Assignees
Labels
type: enhancement New feature or request
Milestone

Comments

@pmprado
Copy link
Contributor

pmprado commented May 1, 2024

Issue Summary

Due to typos, sometimes an endpoint may refer to a port profile that ends up being non-existent due to the typo.
This does not result in errors but it ends up generating configs that do not take the profile in consideration.

Please error out when referring to a profile that can't be found.

Which component(s) of AVD impacted

eos_designs

How do you run AVD ?

Ansible CLI (with virtual-env or native python)

Steps to reproduce

port_profiles:
  - profile: SERVER_A_PROFILE
    mode: trunk
    speed: 10g
    vlans: 2004, 2005, 2016, 2017
servers:
  - name: SERVER-A
    adapters:
      - endpoint_ports: [eth1]
        switch_ports: [Ethernet21]
        switches: [LF01-A]
        profile: SERVER-A-PROFILE
        enabled: true

(note the mixup of dashes vs underscores in the profile name)
The end result understandably does not have the configs from the port profile, but there is no error to be seen.

Relevant log output

(there are no logs, that's the point :) )

Contributing Guide

  • I agree to follow this project's Code of Conduct
@pmprado pmprado added the type: bug Something isn't working label May 1, 2024
@gmuloc gmuloc added the type: enhancement New feature or request label May 6, 2024
@gmuloc gmuloc changed the title Bug(eos_designs): Non-existent profiles are ignored without errors Feat(eos_designs): Non-existent profiles are ignored without errors May 6, 2024
@gmuloc
Copy link
Contributor

gmuloc commented May 6, 2024

Reclassifying it as this is historic behavior and changing it this way. For several minor releases we have been introducing this kind of behavior in other areas of AVD and this would be a good addition.

@gmuloc gmuloc added this to the v5.0.0 milestone May 6, 2024
@gmuloc gmuloc removed the type: bug Something isn't working label May 6, 2024
@pmprado
Copy link
Contributor Author

pmprado commented May 6, 2024

Reclassifying it as this is historic behavior and changing it this way. For several minor releases we have been introducing this kind of behavior in other areas of AVD and this would be a good addition.

Fair enough, but I am curious about the use case of referencing a non-existent profile... any examples?

@gmuloc
Copy link
Contributor

gmuloc commented May 6, 2024

no use case - AVD just did not use to be as helpful as it is now.

Copy link

This issue is stale because it has been open 90 days with no activity. The issue will be reviewed by a maintainer and may be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants