New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor link button issue - followup #1159

Closed
stev0n opened this Issue Nov 14, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@stev0n

stev0n commented Nov 14, 2016

Issue description:

Further to my previous post - Editor - link button -not working #1144

I found that (in my case) the missing editor link/unlink popup and the button tool tips that were missing are just hidden underneath. The can be restored.
I added the below css code to kirki/assets/customizer.css

.wp-full-overlay {
z-index:unset !important;
}

Hope this is helpful.

Regards

Steve

Version used:

(Did you try using the develop branch from github? There's a chance your issue has already been adressed there)

Using theme_mods or options?

Code to reproduce the issue (config + field(s))

@aristath

This comment has been minimized.

Show comment
Hide comment
@aristath

aristath Nov 20, 2016

Owner

@stev0n If I understand correctly, the issue you're seeing is caused by this file: https://github.com/aristath/kirki/blob/develop/assets/scss/controls/editor.scss
Can you please try modifying these lines and see if that fixes your issue? https://github.com/aristath/kirki/blob/develop/assets/css/customizer.css#L593-L611

Owner

aristath commented Nov 20, 2016

@stev0n If I understand correctly, the issue you're seeing is caused by this file: https://github.com/aristath/kirki/blob/develop/assets/scss/controls/editor.scss
Can you please try modifying these lines and see if that fixes your issue? https://github.com/aristath/kirki/blob/develop/assets/css/customizer.css#L593-L611

aristath added a commit that referenced this issue Nov 20, 2016

@aristath

This comment has been minimized.

Show comment
Hide comment
@aristath

aristath Nov 20, 2016

Owner

@stev0n I just pushed a commit in the development branch.

Can you please try pulling this one and see if that fixes your issue?

Owner

aristath commented Nov 20, 2016

@stev0n I just pushed a commit in the development branch.

Can you please try pulling this one and see if that fixes your issue?

aristath added a commit that referenced this issue Nov 20, 2016

@stev0n

This comment has been minimized.

Show comment
Hide comment
@stev0n

stev0n Nov 26, 2016

Hi
Unfortunately, this didn't work.
I will download 2.4.0 and see if this issue goes away.

thanks
steev

stev0n commented Nov 26, 2016

Hi
Unfortunately, this didn't work.
I will download 2.4.0 and see if this issue goes away.

thanks
steev

@aristath

This comment has been minimized.

Show comment
Hide comment
@aristath

aristath Nov 26, 2016

Owner

2.4.0 is highly experimental and a lot of things don't work there.
I wouldn't use it if I were you... it's just used for internal development 'cause I'm rewriting a lot of things in the plugin

Owner

aristath commented Nov 26, 2016

2.4.0 is highly experimental and a lot of things don't work there.
I wouldn't use it if I were you... it's just used for internal development 'cause I'm rewriting a lot of things in the plugin

@stev0n

This comment has been minimized.

Show comment
Hide comment
@stev0n

stev0n Nov 26, 2016

stev0n commented Nov 26, 2016

@aristath aristath modified the milestone: 2.4.0 Dec 10, 2016

@rinkuyadav999

This comment has been minimized.

Show comment
Hide comment
@rinkuyadav999

rinkuyadav999 Jan 8, 2017

Contributor

Nice let fix it here: #1046

Contributor

rinkuyadav999 commented Jan 8, 2017

Nice let fix it here: #1046

@rinkuyadav999

This comment has been minimized.

Show comment
Hide comment
@rinkuyadav999
Contributor

rinkuyadav999 commented Jan 11, 2017

@aristath

This comment has been minimized.

Show comment
Hide comment
@aristath

aristath Mar 28, 2017

Owner

fixed in develop branch.

Owner

aristath commented Mar 28, 2017

fixed in develop branch.

@aristath aristath closed this Mar 28, 2017

@aristath aristath modified the milestones: 2.4.0, 3.0 Mar 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment