New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with visual representation of color picker (alpha iris) #1218

Closed
frasaleksander opened this Issue Dec 20, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@frasaleksander

frasaleksander commented Dec 20, 2016

Issue description:

I am developing WP theme and using TGMPA to download and activate plugins. My theme downloads your plugin from wordpress.org. There is a problem with visual representation of color picker (see the picture).

I've been testing on Google Chrome 55.0.2883.87 (64-bit). Elementary OS (Ubuntu based).

(Probably) The problem is with margin-left calculation of .iris-alpha-slider elements.

Version used:

(Did you try using the develop branch from github? There's a chance your issue has already been adressed there) No, as explained

Using theme_mods or options?

theme_mods

Code to reproduce the issue (config + field(s))

@aristath

This comment has been minimized.

Show comment
Hide comment
@aristath

aristath Dec 20, 2016

Owner

Can you please try the development branch from this repository and let me know if you're still having an issues with that?
I can't do anything about version 2.3.7, except fix it in the next version.
That's what the develop branch here is... a beta version of the next release. 😄

Owner

aristath commented Dec 20, 2016

Can you please try the development branch from this repository and let me know if you're still having an issues with that?
I can't do anything about version 2.3.7, except fix it in the next version.
That's what the develop branch here is... a beta version of the next release. 😄

@frasaleksander

This comment has been minimized.

Show comment
Hide comment
@frasaleksander

frasaleksander Dec 20, 2016

Yes it is still the same. :)

frasaleksander commented Dec 20, 2016

Yes it is still the same. :)

@frasaleksander

This comment has been minimized.

Show comment
Hide comment
@frasaleksander

frasaleksander Dec 20, 2016

quick fix would be: replacing 253rd line in controls/color/wp-color-picker-alpha.js
self.controls[v].width( stripsWidth ).css({ 'margin-left': stripsMargin + 'px' });
with
self.controls[v].width( stripsWidth ).css({ 'margin-left': Math.floor(stripsMargin) + 'px' });

frasaleksander commented Dec 20, 2016

quick fix would be: replacing 253rd line in controls/color/wp-color-picker-alpha.js
self.controls[v].width( stripsWidth ).css({ 'margin-left': stripsMargin + 'px' });
with
self.controls[v].width( stripsWidth ).css({ 'margin-left': Math.floor(stripsMargin) + 'px' });

@aristath aristath closed this in d02e2fb Dec 20, 2016

@aristath

This comment has been minimized.

Show comment
Hide comment
@aristath

aristath Dec 20, 2016

Owner

Well, I can't replicate your issue, but I pushed a commit with those changes anyway.
I hope that fixes your issue! 👍

Owner

aristath commented Dec 20, 2016

Well, I can't replicate your issue, but I pushed a commit with those changes anyway.
I hope that fixes your issue! 👍

@aristath aristath modified the milestone: 3.0 Apr 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment