Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Some resetting issues #1474
Using theme_mods or options?
Code to reproduce the issue (config + field(s))
This field resets to white AND fires the error in point 2
This field turns white but does not fire console error
This field resets fine without error or font turning white
I've had a bit more time to try better pinpoint the issue this morning. I've realised it's due to me using the typography control without a font family field in some instances. Using the below code, setting and resetting the top control will fire the error and turn the text white.
It also happens when using the text align field independently of any other typography settings. This resets the colour but doesn't fire a console error.
I'm happy to change this control to a buttonset though, my concern is more with the top one as it has been useful for me to allow the user to change h1-h6 font sizes but NOT allow them to change the family for each one.
Just to try be thorough in my reporting, I have another control that sets font size but gives a different console error upon reset but also doesn't turn the font white.
I'm having the same issue. On some typography fields I don't set color. Resetting such fields adds
Kirki::add_field( 'theme_config', array( 'type' => 'typography', 'settings' => 'entry_title_link', 'section' => 'headings_typography', 'default' => array( 'letter-spacing' => '0', 'text-transform' => 'none', ), 'priority' => 25, 'transport' => 'auto', 'output' => array( array( 'element' => '.entry-title a', ), ), ) );