New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography line-height normal #1814

Closed
anthonyryanrusso opened this Issue Feb 22, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@anthonyryanrusso

anthonyryanrusso commented Feb 22, 2018

Issue description:

Typography control doesn't allow line-height to be set to "normal"

Version used:

3.0.25

Using theme_mods or options?

theme_mods

Code to reproduce the issue (config + field(s))

Kirki::add_field($opt_name, array( 
    'label' => esc_html__('H1 heading typography', 'konio'),
    'section' => 'general_typography_section',
    'settings' => 'h1_heading_typography',
    'type' => 'typography',
    'default' => array(
        'font-family' => 'Open Sans',
        'font-size' => '40px',
        'line-height' => 'normal',
        'text-transform' => 'none',
        'letter-spacing' => '0px',
        'color' => '#777'
    ),
    'output' => array(
        array(
            'element' => 'h1',
            'property' => 'typography'
        )
    )
));
@anthonyryanrusso

This comment has been minimized.

Show comment
Hide comment
@anthonyryanrusso

anthonyryanrusso Mar 4, 2018

@aristath Any feedback on this?

anthonyryanrusso commented Mar 4, 2018

@aristath Any feedback on this?

@aristath

This comment has been minimized.

Show comment
Hide comment
@aristath

aristath Mar 5, 2018

Owner

Isn't normal the same as 1? (Unitless)

Owner

aristath commented Mar 5, 2018

Isn't normal the same as 1? (Unitless)

@anthonyryanrusso

This comment has been minimized.

Show comment
Hide comment
@anthonyryanrusso

anthonyryanrusso Mar 5, 2018

No unfortunately "1" is not the same as "normal".

According to the spec, a value of "normal" is not just a single concrete value that is applied to all elements, but rather computes to a "reasonable" value depending on the font size set (or inherited) on the element.

anthonyryanrusso commented Mar 5, 2018

No unfortunately "1" is not the same as "normal".

According to the spec, a value of "normal" is not just a single concrete value that is applied to all elements, but rather computes to a "reasonable" value depending on the font size set (or inherited) on the element.

@aristath aristath closed this in 640e2a8 Mar 11, 2018

@aristath

This comment has been minimized.

Show comment
Hide comment
@aristath

aristath Mar 11, 2018

Owner

Fixed. Problem was with the sanitization function 👍

Owner

aristath commented Mar 11, 2018

Fixed. Problem was with the sanitization function 👍

@aristath aristath added this to the 3.0.26 milestone Mar 17, 2018

aristath added a commit that referenced this issue Mar 17, 2018

Merge branch 'develop' into postMessage-refactor
* develop: (73 commits)
  fixes #1730
  fixes #1830
  GDPR: Load webfont-loader locally
  Update fonts
  fixes #1834
  Apply WordPress Coding Standards
  Update kirki-helper-class.md
  see #1797
  cleanup unused vars
  See #1807
  Additional fix for #1809
  fixes #1828
  fixes #1808
  fix #1814
  fix #1797
  fixes #1809
  Update sortable.md
  fixes #1787
  update webfonts & grunt
  changelog
  ...

# Conflicts:
#	modules/postmessage/class-kirki-modules-postmessage.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment