Permalink
Commits on Nov 10, 2012
  1. Ask for a confirmation before initiating the build.

    Although it is mentioned in http://phantomjs.org/build.html, many people
    are not aware this, they compile from source (even if a binary package
    is available) and get shocked to realize the build takes ages.
    The build script is thus modified to give the initial warning.
    
    Unattended build is still possible, just use --confirm flag.
    
    http://code.google.com/p/phantomjs/issues/detail?id=862
    committed Nov 10, 2012
  2. Stop potential crash by guarding the access to the page.

    Based on the work from Shawn Krisman (krisman.shawn@gmail.com).
    
    http://code.google.com/p/phantomjs/issues/detail?id=719
    committed Sep 24, 2012
  3. Revert breaking behavior in commit ecda224.

    Keeping the page alive instead of destroying causes unexpected behavior
    compared to version 1.6 and earlier. See the discussion:
    https://groups.google.com/d/topic/phantomjs/C84fmd21LDk/.
    
    http://code.google.com/p/phantomjs/issues/detail?id=719
    committed Sep 24, 2012
Commits on Sep 23, 2012
  1. Merge branch 'master' into 1.7

    committed Sep 23, 2012
  2. Advertise the migrated wiki pages.

    committed Sep 23, 2012
  3. Undocument the callback mechanism.

    This is private for now, see issue 133 for details.
    
    http://code.google.com/p/phantomjs/issues/detail?id=133
    committed Jun 19, 2012
Commits on Sep 22, 2012
  1. Remove non-working weather example.

    The example stops working since the request is blocked. It needs a
    rewrite to use a different service.
    
    http://code.google.com/p/phantomjs/issues/detail?id=794
    committed Sep 22, 2012
Commits on Sep 21, 2012
  1. Merge branch 'master' into 1.7

    committed Sep 21, 2012
  2. Remove outdated Debian control files.

    Rather than advertising wrong info (PyPhantomJS etc), debian/ is
    removed until new up-to-date content is prepared.
    
    http://code.google.com/p/phantomjs/issues/detail?id=793
    committed Sep 21, 2012
  3. Fixing issue with CookieJar not loading at boot.

    * Using the "QTimer::singleShot" bites back in the ass
    * The "script" takes priority and runs before the SLOT is actually invoked
    
    Why was I using a Timer?
    Not sure anymore: it must have slipped in while I was trying to work out
    all the other issues I had with QNetworkCookieJar, and I left it there.
    
    http://code.google.com/p/phantomjs/issues/detail?id=790
    detro committed with Sep 21, 2012
  4. Merge branch 'master' into 1.7

    committed Sep 21, 2012
  5. Non-zero exit code if any test fails.

    In the callback function passed to `waitFor`, the call to `page.evaluate`
    returns a 1 or 0, and this is then passed to `phantom.exit` (with a 1
    indicating at least one test failed, 0 indicating all tests passed).
    
    http://code.google.com/p/phantomjs/issues/detail?id=792
    ianoxley committed with Sep 11, 2012
  6. Added 'tests passed' message.

    If all tests pass, a message indicating this is output to the console.
    
    http://code.google.com/p/phantomjs/issues/detail?id=792
    ianoxley committed with Sep 11, 2012
  7. Test failure CSS selectors changed.

    Changed the CSS selectors used to identify failed tests.
    
    The old selector was `div.jasmine_reporter > div.suite.failed`,
    but this no longer seems to match any elements.
    
    The new selector is `.results > #details > .specDetails.failed`. For each
    failing test the `.description` and `.resultMessage.fail` elements are
    used to output the failures to the console.
    
    http://code.google.com/p/phantomjs/issues/detail?id=792
    ianoxley committed with Sep 11, 2012
  8. Changed CSS selector used when checking for whether tests have finished.

    When using the jasmine 1.2.0 standalone version, `.runner .description`
    doesn't seem to match any elements.
    
    I noticed pending tests can be found using the CSS selector
    `.symbolSummary .pending`, so changed the testFx callback to check
    that no elements are left matching this selector.
    
    http://code.google.com/p/phantomjs/issues/detail?id=792
    ianoxley committed with Sep 11, 2012
  9. Revert "Fix crash on exit (Issues #136, #148 and #149)"

    This reverts commit 5acaa6b.
    
    Conflicts:
    
    	src/phantom.cpp
    	src/phantom.h
    
    removed m_page deletion.
    
    http://code.google.com/p/phantomjs/issues/detail?id=719
    Shawn Krisman committed with Aug 19, 2012
  10. Make the key enums as part of WebPage instance.

    This way, we don't add anything into phantom object.
    
    http://code.google.com/p/phantomjs/issues/detail?id=492
    committed Sep 21, 2012
Commits on Sep 20, 2012
Commits on Sep 19, 2012
  1. Merge pull request #319 from detro/ghostdriver-dev

    GhostDriver Development Branch - Master Push #4
    committed Sep 19, 2012
Commits on Sep 18, 2012
  1. Made the "Callbacks injection" recursive.

    Before this, only the first level of child frames had the possibility to use
    the Callbacks object. Now is injected recursively in all of them.
    
    This is an extension of coverage for [Issue #683](http://code.google.com/p/phantomjs/issues/detail?id=683).
    detro committed Sep 18, 2012