Fix mongoose build warnings on Windows #10348

Closed
execjosh opened this Issue Jan 13, 2012 · 8 comments

Projects

None yet

3 participants

@execjosh
Contributor

With Qt Creator 2.4.0 Desktop Qt 4.7.3 on Win7, which apparently uses mingw32 4.4.0, mongoose builds with some warnings.

These warnings might not be seen when building in a *nix environment.

See discussion: #172 (comment)

Disclaimer:
This issue was migrated on 2013-03-15 from the project's former issue tracker on Google Code, Issue #348.
🌟   2 people had starred this issue at the time of migration.

Contributor
milianw commented Jan 13, 2012

m...@milianw.de commented:

please report this issue upstream at the mongoose project like I told you in the pull request's discussion.

Contributor

Yes, will do. This is just a reminder.

Owner
ariya commented Jan 15, 2012

ariya.hi...@gmail.com commented:

Should we do something (patch our own copy) or should we just wait until upstream Mongoose is fixed?

 
Metadata Updates

  • Label(s) removed:
    • Type-Defect
  • Label(s) added:
    • Type-Enhancement
    • Module-WebServer
    • Component-BuildSystem
  • Milestone updated: Release1.5 (was: ---)
Contributor
milianw commented Jan 15, 2012

m...@milianw.de commented:

This decision is up to you Ariya, you are the project lead after all :) Considering that this is purely about silencing build time warnings, I wouldn't think it's worth the effort.

Contributor

I prefer "zero warnings"; but, since the warnings are only apparent on a specific platform/build env, I also think we can just wait for upstream Mongoose to be fixed.

BTW, I submitted the patch here: http://code.google.com/p/mongoose/issues/detail?id=308

Owner
ariya commented Jan 16, 2012

ariya.hi...@gmail.com commented:

Let's see if by the time we approach PhantomJS 1.5 release and there is no fix upstream, then we will patch our own copy.

 
Metadata Updates

  • Status updated: Accepted
Owner
ariya commented Mar 15, 2012

ariya.hi...@gmail.com commented:

Non critical, rescheduled.

 
Metadata Updates

  • Milestone updated: FutureRelease (was: Release1.5)
Contributor
execjosh commented May 9, 2013

This can be closed, I guess...

@execjosh execjosh closed this May 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment