Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Phantom 1.8.0 segfaults when appending and removing an iframe (YUITest) #10947

Closed
davglass opened this issue Dec 29, 2012 · 52 comments
Closed

Phantom 1.8.0 segfaults when appending and removing an iframe (YUITest) #10947

davglass opened this issue Dec 29, 2012 · 52 comments
Assignees
@ariya
Labels
Bug Crash

Comments

@davglass
Copy link

davgl...@gmail.com commented:

This gist contains all the info (repro script, dump file, etc):

https://gist.github.com/4399116

Disclaimer:
This issue was migrated on 2013-03-15 from the project's former issue tracker on Google Code, Issue #947.
🌟   38 people had starred this issue at the time of migration.
@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Confirm on Windows 7 x64.
PhantomJS 1.9.0 (dev).

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Crash dump attached

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Due to these lines of code
webpage.cpp:326

connect(m_customWebPage, SIGNAL(frameCreated(QWebFrame_)), this, SLOT(setupFrame(QWebFrame_)), Qt::QueuedConnection);

webpage.cpp:1448

void WebPage::setupFrame(QWebFrame *frame)

@ariya
Copy link
Owner

ariya commented Dec 29, 2012

ariya.hi...@gmail.com commented:

Vitaliy, if you comment out deleteLater() in WebPage::close(), does it still crash for you?

Additional info: issue 690 (Crash with TrueType font).

 
Metadata Updates

  • Label(s) added:
    • Component-Logic
  • Milestone updated: FutureRelease (was: ---)
  • Status updated: Accepted

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Yes, it does.

@JamesMGreene
Copy link
Collaborator

james.m....@gmail.com commented:

Issue 956 has been merged into this issue.

@JamesMGreene
Copy link
Collaborator

james.m....@gmail.com commented:

 

 
Metadata Updates

  • Label(s) removed:
    • Priority-Medium
  • Label(s) added:
    • Priority-High
    • Module-WebPage
    • Domain-Qt
  • Milestone updated: Release1.9 (was: FutureRelease)
  • Title updated: Phantom 1.8.0 segfaults when appending and removing an iframe (YUITest)

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 966 has been merged into this issue.

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 971 has been merged into this issue.

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 981 has been merged into this issue.

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 986 has been merged into this issue.

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 991 has been merged into this issue.

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 1014 has been merged into this issue.

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 1016 has been merged into this issue.

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Discussion: https://groups.google.com/forum/?fromgroups#!topic/phantomjs/uKTIEYenw78

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 1006 has been merged into this issue.

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 1019 has been merged into this issue.

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 1023 has been merged into this issue.

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 1026 has been merged into this issue.

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 1025 has been merged into this issue.

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 1024 has been merged into this issue.

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 1011 has been merged into this issue.

@ariya
Copy link
Owner

ariya commented Jan 29, 2013

ariya.hi...@gmail.com commented:

Prevent possible crash on pages with iframes.
43ab20d4ae

@ariya
Copy link
Owner

ariya commented Jan 29, 2013

mrsa...@gmail.com commented:

After making the change mentioned in #25 I am no longer seeing segfaults on specific pages.

@JamesMGreene
Copy link
Collaborator

james.m....@gmail.com commented:

 

 
Metadata Updates

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 1033 has been merged into this issue.

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 1048 has been merged into this issue.

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 1046 has been merged into this issue.

@ariya
Copy link
Owner

ariya commented Feb 8, 2013

magnus.s...@gmail.com commented:

This seems to fix Issue 951 as well.

@vitallium
Copy link
Collaborator

vitaliy....@gmail.com commented:

Issue 1050 has been merged into this issue.

This was referenced Mar 15, 2013
Closed
Closed
Closed
Closed
Closed
Closed
@ariya ariya mentioned this issue Mar 15, 2013
Closed
This was referenced Mar 15, 2013
Closed
Closed
Closed
@shane-tomlinson shane-tomlinson mentioned this issue Apr 27, 2013
Closed
@mandarille mandarille mentioned this issue Feb 17, 2014
Closed
ariya pushed a commit that referenced this issue Feb 20, 2014
@ariya
Fix for crash bug caused by Iframe NULL reference
bda8838 
#10947
#11103
#11984
encounter added a commit to encounter/phantomjs that referenced this issue Apr 10, 2014
@encounter
Crash fix: Switch to top frame when parent frame is reloaded
6379918 
Fixes ariya#10947 ariya#11103 ariya#11984
encounter added a commit to encounter/phantomjs that referenced this issue Jan 28, 2015
@encounter
Crash fix: Switch to top frame when parent frame is reloaded
4c010f0 
Fixes ariya#10947 ariya#11103 ariya#11984
zackw pushed a commit to zackw/phantomjs that referenced this issue Dec 23, 2015
@encounter @zackw
Crash fix: Switch to top frame when current frame is destroyed.
e419133 
Originally pull request ariya#12109.
Fixes issues ariya#10947 ariya#11103 ariya#11984 ariya#13551 and probably more.

The test case is a composite of test cases provided by
Luke Street (ariya#12109) and kramsee (ariya#13551).
@zackw zackw modified the milestones: Release 2.1, Release1.9 Dec 23, 2015
@zackw
Copy link
Collaborator

zackw commented Dec 23, 2015

Turns out we didn't fix this properly until just now.

igorshapiro pushed a commit to WiserSolutions/phantomjs that referenced this issue Sep 29, 2016
@encounter @igorshapiro
Crash fix: Switch to top frame when current frame is destroyed.
9a0e3f5 
Originally pull request ariya#12109.
Fixes issues ariya#10947 ariya#11103 ariya#11984 ariya#13551 and probably more.

The test case is a composite of test cases provided by
Luke Street (ariya#12109) and kramsee (ariya#13551).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ariya ariya

Labels
Bug Crash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ariya @davglass @zackw @JamesMGreene @vitallium