Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for locale-specific toLocaleString formatting? #12327

Closed
kbullaughey opened this issue Jun 21, 2014 · 2 comments
Closed

support for locale-specific toLocaleString formatting? #12327

kbullaughey opened this issue Jun 21, 2014 · 2 comments

Comments

@kbullaughey
Copy link

@kbullaughey kbullaughey commented Jun 21, 2014

I would have expected (10000).toLocaleString('en') to return "10,000" but instead I get "10000".

Is there a reason this is not supported? or Am I doing something wrong? Are there better ways to format numbers?

@JamesMGreene
Copy link
Collaborator

@JamesMGreene JamesMGreene commented Jun 21, 2014

I'm sure you'd be much better off using a library like Globalize.js (formerly "jquery.globalize"), Intl.js, the Jed Toolkit, etc.

@kbullaughey
Copy link
Author

@kbullaughey kbullaughey commented Jun 21, 2014

Thanks. I'll do that.

Mr0grog added a commit to Mr0grog/5calls that referenced this issue Feb 11, 2017
The basic idea here is that we compile test files with Browserify at `app/test`. An HTML file that forms the test runner lives at `static/test/test.html` and gets built to `app/test/test.html`.

Caveats:

Source maps don’t work for stack traces -- files need to be served over HTTP for that.

This makes the callcount tests fail -- it turns out PhantomJS does not support `.toLocalString()`. See:
  ariya/phantomjs#12327 and
  ariya/phantomjs#12581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants