Regression in encoding.cpp #14632

Open
jowiho opened this Issue Nov 7, 2016 · 3 comments

Projects

None yet

3 participants

@jowiho
Contributor
jowiho commented Nov 7, 2016

The (refactoring) commit 9d1c6b9 introduced a bug in encoding.cpp. The comparison on line 76 was accidentally reverted, which effectively renders setEncoding useless.

@jowiho jowiho added a commit to jowiho/phantomjs that referenced this issue Nov 7, 2016
@jowiho jowiho Fix regression in setEncoding introduced in 9d1c6b9
This corrects the comparison reversion accidentally introduced in commit 9d1c6b9.

Issue: ariya#14632
1e63191
@zackw
Collaborator
zackw commented Nov 7, 2016
@Vitallium
Collaborator

Whoops. Damn. Nice catch! We definitely need a test for it. But we also have a bunch of failing tests. These tests should be fixed too.

@jowiho
Contributor
jowiho commented Nov 8, 2016

If I can find the time, I could have a look at adding a test. But I'll wait for the new build instructions first. Currently I can't even figure out how to build the project. :-)

@Vitallium Vitallium added a commit that referenced this issue Jan 5, 2017
@jowiho @Vitallium jowiho + Vitallium Fix regression in setEncoding introduced in 9d1c6b9 (#14633)
This corrects the comparison reversion accidentally introduced in commit 9d1c6b9.

Issue: #14632
928d635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment