Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Importing GhostDriver v1.0.3 #11146

Merged
merged 3 commits into from
+5,205 −2,508

2 participants

@detro
Collaborator

Fixes and (minor) new features are described at: https://github.com/detro/ghostdriver/issues?labels=1.0.3&page=1&state=closed

PS I know I have "push rights" now, but I do think in code review. PARTICULARLY when it's such a big thing :)

@detro detro New "page.loading" and "page.loadingProgress".
Now you can know about the Page Loading Progress
using 2 property:
- [bool] page.loading
- [int: 0-100] page.loadingProgress

Implements #1091: http://code.google.com/p/phantomjs/issues/detail?id=1091
9740990
@ariya
Owner

Probably link #11091 from commit 6a1d92b. Although it looks weird, adding the link to this one (#11146) from commit dcd4932 will be very useful to reference back this PR just from looking/browsing the commit log.
Otherwise, LGTM.

detro added some commits
@detro detro Tests for the new "page.loading" property.
This commit provides the unit tests for the new property, as asked by
Ariya in #11091.
005db03
@detro detro Importing new GhostDriver 1.0.3.
See the https://github.com/detro/ghostdriver/ project for details.
78d9064
@detro detro merged commit 6989188 into from
@ariya
Owner

BTW what's your thought on 1.9? See the recent mailing-list topic. I'm curious to know whether this 1.0.3 is something you want to be out ASAP or whether it can wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 17, 2013
  1. @detro

    New "page.loading" and "page.loadingProgress".

    detro authored
    Now you can know about the Page Loading Progress
    using 2 property:
    - [bool] page.loading
    - [int: 0-100] page.loadingProgress
    
    Implements #1091: http://code.google.com/p/phantomjs/issues/detail?id=1091
Commits on Mar 18, 2013
  1. @detro

    Tests for the new "page.loading" property.

    detro authored
    This commit provides the unit tests for the new property, as asked by
    Ariya in #11091.
  2. @detro

    Importing new GhostDriver 1.0.3.

    detro authored
    See the https://github.com/detro/ghostdriver/ project for details.
Something went wrong with that request. Please try again.