Skip to content

Fix issue with localstorage is not written to --local-storage-path option value #11185

Closed
wants to merge 1 commit into from

3 participants

@Havelock-Vetinari

Added offlineStoragePath to:

  • setOfflineWebApplicationCachePath
  • setLocalStoragePath

#10716

@Havelock-Vetinari Havelock-Vetinari localstorage is not written to --local-storage-path option value
Added offlineStoragePath to:
 * setOfflineWebApplicationCachePath
 * setLocalStoragePath

ariya#10716
0291831
@JamesMGreene
Collaborator

Thanks for contributing. We have a similar pending PR #404 which also aims to cover enabling configuration of the other types of storage, too.

The PR needs some love as you can see from reading through the comments and unraveling all the confusion we talked through... but I would prefer to see that PR get merged instead. It needs to be mostly rewritten (and have many variable and method names updated) after our discussion ended but the original submitter has not gotten around to it, so you're welcomed to take over if you like.

@Vitallium
Collaborator

Closing this PR because it's outdated.

@Vitallium Vitallium closed this May 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.