Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing GhostDriver 1.1.0 in PhantomJS. #11877

Closed
wants to merge 1 commit into from
Closed

Conversation

@detro
Copy link
Collaborator

detro commented Jan 4, 2014

CHANGELOG for v1.1.0 (https://github.com/detro/ghostdriver/issues?labels=1.1.0&state=closed)

JavaScript Driver (Core)

  • ENHANCEMENT: /maximize window will set the window size to 1336x768,
    currently most common resolution online (see http://gs.statcounter.com/#resolution-ww-monthly-201307-201312)
  • ENHANCEMENT #275: Implemented Browser and Network (HAR) Logging types
  • FIXED #284: Attempt to wait for Page to Load if input causes form submit
  • FIXED #291: Throw exception when attempting to set invalid timeout value
  • FIXED #259: Fix issue regarding mouse clicks
  • ENHANCEMENT #290: Enabled support for "Keep Alive" HTTP connections
  • ENHANCEMENT #262: Allow access to PhantomJS API from WebDriver (Driver part)
  • ENHANCEMENT #293: Import Selenium 2.39.0 WebDriver Atoms

Java Binding

  • MINOR #251: Minor compilation issues for Binding
  • ENHANCEMENT #262: Allow access to PhantomJS API from WebDriver (Java Binding part)

Tested using GhostDriver validation tests (https://github.com/detro/ghostdriver/tree/master/test).

CHANGELOG for v1.1.0 (https://github.com/detro/ghostdriver/issues?labels=1.1.0&state=closed)

JavaScript Driver (Core)
* ENHANCEMENT: `/maximize` window will set the window size to 1336x768,
currently most common resolution online (see http://gs.statcounter.com/#resolution-ww-monthly-201307-201312)
* ENHANCEMENT #275: Implemented Browser and Network (HAR) Logging types
* FIXED #284: Attempt to wait for Page to Load if input causes form submit
* FIXED #291: Throw exception when attempting to set invalid timeout value
* FIXED #259: Fix issue regarding mouse clicks
* ENHANCEMENT #290: Enabled support for "Keep Alive" HTTP connections
* ENHANCEMENT #262: Allow access to PhantomJS API from WebDriver (Driver part)
* ENHANCEMENT #293: Import Selenium 2.39.0 WebDriver Atoms

Java Binding
* MINOR #251: Minor compilation issues for Binding
* ENHANCEMENT #262: Allow access to PhantomJS API from WebDriver (Java Binding part)

Tested using GhostDriver validation tests (https://github.com/detro/ghostdriver/tree/master/test).
@ariya
Copy link
Owner

ariya commented Jan 4, 2014

BTW, is Keep Alive the default now?

@detro
Copy link
Collaborator Author

detro commented Jan 4, 2014

Yes, I have enabled support for "keep alive" in GhostDriver connections.

Latest Selenium assumes drivers support HTTP Keep Alive.
Of course, it's retro compatible: unless requested by the client, the behaviour shouldn't change.

I say "shouldn't" as it's down to Mongoose really: if the keep alive option does what it says on the tin, we are ok.

@ariya
Copy link
Owner

ariya commented Jan 4, 2014

I recall some problem wiht Mongoose when Keep Alive is used. But my memory is hazy.
Probably another good reason to switch away from it.

In all cases, let me test this change.

detro added a commit that referenced this pull request Jan 5, 2014
CHANGELOG for v1.1.0 (https://github.com/detro/ghostdriver/issues?labels=1.1.0&state=closed)

JavaScript Driver (Core)
* ENHANCEMENT: `/maximize` window will set the window size to 1336x768,
currently most common resolution online (see http://gs.statcounter.com/#resolution-ww-monthly-201307-201312)
* ENHANCEMENT #275: Implemented Browser and Network (HAR) Logging types
* FIXED #284: Attempt to wait for Page to Load if input causes form submit
* FIXED #291: Throw exception when attempting to set invalid timeout value
* FIXED #259: Fix issue regarding mouse clicks
* ENHANCEMENT #290: Enabled support for "Keep Alive" HTTP connections
* ENHANCEMENT #262: Allow access to PhantomJS API from WebDriver (Driver part)
* ENHANCEMENT #293: Import Selenium 2.39.0 WebDriver Atoms

Java Binding
* MINOR #251: Minor compilation issues for Binding
* ENHANCEMENT #262: Allow access to PhantomJS API from WebDriver (Java Binding part)

Tested using GhostDriver validation tests (https://github.com/detro/ghostdriver/tree/master/test).

#11877
@ariya
Copy link
Owner

ariya commented Jan 5, 2014

Landed. Thank you!

@ariya ariya closed this Jan 5, 2014
detro added a commit that referenced this pull request Jan 19, 2014
CHANGELOG for v1.1.0 (https://github.com/detro/ghostdriver/issues?labels=1.1.0&state=closed)

JavaScript Driver (Core)
* ENHANCEMENT: `/maximize` window will set the window size to 1336x768,
currently most common resolution online (see http://gs.statcounter.com/#resolution-ww-monthly-201307-201312)
* ENHANCEMENT #275: Implemented Browser and Network (HAR) Logging types
* FIXED #284: Attempt to wait for Page to Load if input causes form submit
* FIXED #291: Throw exception when attempting to set invalid timeout value
* FIXED #259: Fix issue regarding mouse clicks
* ENHANCEMENT #290: Enabled support for "Keep Alive" HTTP connections
* ENHANCEMENT #262: Allow access to PhantomJS API from WebDriver (Driver part)
* ENHANCEMENT #293: Import Selenium 2.39.0 WebDriver Atoms

Java Binding
* MINOR #251: Minor compilation issues for Binding
* ENHANCEMENT #262: Allow access to PhantomJS API from WebDriver (Java Binding part)

Tested using GhostDriver validation tests (https://github.com/detro/ghostdriver/tree/master/test).

#11877
@ariya
Copy link
Owner

ariya commented Jan 21, 2014

@detro Does this require the new CookieJar implementation? I cherry-pick these (and 1.1.1) to 1.9 branch and it seems to cause some problem, see #11905 (comment).

/cc @vitallium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.