Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

All local storage paths in one directory and config argument. #12009

Open
wants to merge 2 commits into from

2 participants

@epowers

Currently phantomjs stores offline application cache data and what it calls local storage data in a shared directory, while phantomjs has a command-line parameter for such data. This patch places all of this data into the user-specified directory (--local-storage-path) so that it is possible to run multiple independent phantomjs sessions in separate processes in a single user session on a system.

This will affect any existing user of --local-storage-path who also uses offline application storage in their site.

Please note, the navigator.onLine osx change might cause build problems on non-osx. Probably need some modifications to the bearer.pro file that comments out building for anything other than osx. But I'm not familiar with .pro files enough to blindly make those changes without testing. So please consider immediately testing a build and modify that file to handle building bearer for mac but not for other systems.

epowers added some commits
@epowers epowers All local storage paths in one directory and config argument. 43a34cc
@epowers epowers navigator.onLine OSX support added; qt plugin corewlan on osx enables…
… webkit to detect if the network is online, then reflect that status in the browser; this patch pulls code from qt 4.8 into the phantomjs source tree to add corewlan to mac builds.
12d3511
@ariya
Owner

Thanks for the patch. Please read the contribution guide and follow the process there. In particular, look for past issues/PR related to the local storage path. Also, navigator.onLine should be a separate discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 25, 2014
  1. @epowers
Commits on Feb 26, 2014
  1. @epowers

    navigator.onLine OSX support added; qt plugin corewlan on osx enables…

    epowers authored
    … webkit to detect if the network is online, then reflect that status in the browser; this patch pulls code from qt 4.8 into the phantomjs source tree to add corewlan to mac builds.
Something went wrong with that request. Please try again.