Support contextmenu ("right click") events using sendEvent('contextmenu') #13870
Conversation
Depends on ariya/phantomjs#13870 Fixes #125
|
Do we have an issue filed for this yet? If not, please do so. See the contribution guidelines for the details. |
Phantomjs issue ariya#11429 Fixes ariya#11429 by allowing to send a "contextmenu" event. Intentionally does not map a "click" event using "right" button into contextmenu event because this would be inconsistent with how browsers work. Related issue in Ghostdriver: https://github.com/detro/ghostdriver/issues/125
|
Update commit message with link to PhantomJS issue: #11429 and Ghostdriver issue: https://github.com/detro/ghostdriver/issues/125 |
|
LGTM |
|
Is the Ghostdriver project (https://github.com/detro/ghostdriver/) still used in PhantomJS or should I include the Ghostdriver patch for the local copy in this PR also? |
|
@Artur- it's still used. But it's a bit outdated. We have included the streamline copy of Ghostdriver. All Ghostdriver related changes must be submitted against the original repo. |
|
Ok, detro/ghostdriver#472 is already there waiting for approval |
|
@Artur- Thanks! I'll merge current pull request in a few minutes. |
|
Sorry for taking it so long. Landed in master (20d673b) Thank you! |
No description provided.