Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fix crash on close #232

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

milianw commented Apr 11, 2012

selectWorker was uninitialized in QEventDispatcherQPAPrivate and leads to a crash on close when the invalid pointer adress is tried to be deleted

Contributor

milianw commented Apr 11, 2012

sorry, forgot the issue, here it is now: http://code.google.com/p/phantomjs/issues/detail?id=497

Owner

ariya commented Apr 11, 2012

Looks good but can you start using proper capitalization and punctuation in the commit log?

Contributor

milianw commented Apr 11, 2012

ok sorry, will do in the future. should I redo the pull request? a more fitting commit message could be:

Fix crash on close due to an uninitialized pointer in QEventDispatcherQPAPrivate.
Owner

ariya commented Apr 11, 2012

If you ammend the commit and push again (with -f), I think this pull request should be updated. Thanks!

Contributor

milianw commented Apr 11, 2012

ok done, I didn't know about that feature. thanks

Owner

ariya commented Apr 12, 2012

Merged. Also backported to 1.5 branch. Thank you!

@ariya ariya closed this Apr 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment