Add missing pageref attribute to HAR and end-time #306

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@igrigorik

The pageref attribute is required to associate the requests with the appropriate pages. Without it, many tools fail to interpet the data.

Also, added the "onLoad" timer, albeit I'm not 100% sure that the way I have it there is the best way to do it. I tried adding an onLoadFinished callback, but for whatever reason, it just didn't want to fire. Any tips?

Also, I'd love to surface other data such as onDomContentLoaded - is there any way to register this callback? Or, alternatively, is there any way to get access to the performance timing data from phantom? Does the QT port support it?

@ariya
Owner
ariya commented Aug 28, 2012

I've created an issue https://code.google.com/p/phantomjs/wiki/ContributionGuide for discussion (main reason: this GitHub pull request is not searchable at all).

@ariya
Owner
ariya commented Aug 28, 2012

Merged (as squashed). Thanks!

@ariya ariya closed this Aug 28, 2012
@igrigorik

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment