This repository has been archived by the owner. It is now read-only.

Use fs.write in the example for clarity. #409

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@barraponto
Contributor

barraponto commented Feb 19, 2013

I think fs.write() makes the code a lot clearer than file.writeline(). It's a good way to show PhantomJS API as well.

@JamesMGreene

This comment has been minimized.

Show comment
Hide comment
@JamesMGreene

JamesMGreene Feb 19, 2013

Collaborator

Hmm, I can see your point there. I'm OK with this change.

Please squash your commits into a single commit.

Collaborator

JamesMGreene commented Feb 19, 2013

Hmm, I can see your point there. I'm OK with this change.

Please squash your commits into a single commit.

Use fs.write in the example for clarity.
Leave the try/catch block.

use fs.write in the coffee example as well
@barraponto

This comment has been minimized.

Show comment
Hide comment
@barraponto

barraponto Feb 20, 2013

Contributor

Squashed :)

Contributor

barraponto commented Feb 20, 2013

Squashed :)

@ariya

This comment has been minimized.

Show comment
Hide comment
@ariya

ariya Feb 24, 2013

Owner

Landed with some tweaks: include the issue link (see the contribution guide), remove extra whitespace.

Thank you!

Owner

ariya commented Feb 24, 2013

Landed with some tweaks: include the issue link (see the contribution guide), remove extra whitespace.

Thank you!

@ariya ariya closed this Feb 24, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.