Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fs.write in the example for clarity. #409

Closed
wants to merge 1 commit into from

Conversation

@barraponto
Copy link
Contributor

barraponto commented Feb 19, 2013

I think fs.write() makes the code a lot clearer than file.writeline(). It's a good way to show PhantomJS API as well.

@JamesMGreene
Copy link
Collaborator

JamesMGreene commented Feb 19, 2013

Hmm, I can see your point there. I'm OK with this change.

Please squash your commits into a single commit.

Leave the try/catch block.

use fs.write in the coffee example as well
@barraponto
Copy link
Contributor Author

barraponto commented Feb 20, 2013

Squashed :)

@ariya
Copy link
Owner

ariya commented Feb 24, 2013

Landed with some tweaks: include the issue link (see the contribution guide), remove extra whitespace.

Thank you!

@ariya ariya closed this Feb 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.