Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the package by using the swagger-ui-dist npm package #36

Merged
merged 1 commit into from Aug 3, 2018

Conversation

@Raptor399
Copy link
Contributor

Raptor399 commented Jul 20, 2018

It's not good practice to copy dependency files into your own project - case in point: the swagger-ui files. This change adds a swagger-ui-dist dependency to the package.json, which should make VS Code download and install the required swagger-ui files to the "node_modules/swagger-ui/" directory.

To be able to reach those files, the local server now points to the top directory. Two HTML files were moved to keep http://localhost:9000 working as before, and the static directory with all of its duplicate code was deleted.

For local testing purposes, use npm install to download the swagger-ui files before testing.

… of including its files. Run `npm install` to test locally.
@Raptor399 Raptor399 mentioned this pull request Jul 20, 2018
@arjun-g

This comment has been minimized.

Copy link
Owner

arjun-g commented Aug 3, 2018

There is little problem with this change. The node_modules folders is not marked as static folder in express. Anyhow I am merging it and will fix it from my side.

@arjun-g arjun-g merged commit 62ad2e1 into arjun-g:master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.