Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSimplify the package by using the swagger-ui-dist npm package #36
Conversation
… of including its files. Run `npm install` to test locally.
Closed
This comment has been minimized.
This comment has been minimized.
|
There is little problem with this change. The node_modules folders is not marked as static folder in express. Anyhow I am merging it and will fix it from my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Raptor399 commentedJul 20, 2018
It's not good practice to copy dependency files into your own project - case in point: the swagger-ui files. This change adds a
swagger-ui-distdependency to thepackage.json, which should make VS Code download and install the required swagger-ui files to the "node_modules/swagger-ui/" directory.To be able to reach those files, the local server now points to the top directory. Two HTML files were moved to keep http://localhost:9000 working as before, and the
staticdirectory with all of its duplicate code was deleted.For local testing purposes, use
npm installto download the swagger-ui files before testing.