Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Fix ed-on-mnt4-753 #45

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Fix ed-on-mnt4-753 #45

merged 2 commits into from
Feb 9, 2021

Conversation

weikengchen
Copy link
Member

@weikengchen weikengchen commented Feb 9, 2021

Description

The current repo has two small issues regarding ed-on-mnt4-753

  • we forgot to include it in the workspace Cargo.toml, so the CI never tested it, and cargo fmt never touched it.
  • the curve parameters for ed-on-mnt4-753 was expressed as a mix of the old BigInt representation and the new field_new representation.

This PR fixes it, by including it in the workspace Cargo.toml as well as cleaning up the curve parameters.


  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@weikengchen weikengchen changed the title Fix ed-mnt4-753 Fix ed-on-mnt4-753 Feb 9, 2021
@Pratyush Pratyush merged commit 666da1e into master Feb 9, 2021
@Pratyush Pratyush deleted the fix-ed-mnt4-753 branch February 9, 2021 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants