Don't close notification until verification succeeds. #68
Conversation
| @@ -377,6 +377,9 @@ var ui = { | |||
| callback: function() { | |||
| let name = uiConv.target.normalizedName; | |||
| ui.openAuth(window, otrAuth, name, "start", uiConv); | |||
|
|
|||
| // prevent closing of notification bar when the button is hit | |||
| throw new Error('prevent nb close'); | |||
| return false; | |||
Throwing an error is undesirable, but thankfully I think returning true here seems to work.
Yep, this is definitely better style.
|
Thanks for the pull. Can you amend the patch (after verifying my review) and force push to your branch? |
|
Ok, my patch is updated to include the |
|
Great! Merged in 40f7542 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This fixes #62: the notification bar is hindered from being closed by the verification dialog.
However, while the XUL documentation states this can be done by throwing an error in the
eventCallbackfunction ofappendNotification, this did not work for me. I instead put thethrowinto the callback function of the button.I also opened a post on stackoverflow on this issue, since I don't see why the method described in the documentation should not work.
The text was updated successfully, but these errors were encountered: