Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve verifying from fingerprint manager #71

Closed
wants to merge 1 commit into from
Closed

Improve verifying from fingerprint manager #71

wants to merge 1 commit into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@vqhuy @arlolra
@vqhuy
Copy link
Collaborator

@vqhuy vqhuy commented Mar 13, 2016

  • Part of #59
  • Offer all methods for verifying
  • Update status of fingerprint after verification.
arlolra
arlolra reviewed Mar 14, 2016
View changes
chrome/content/finger.js
finger.trust = otr.isFingerprintTrusted(finger.fpointer);
if (context) {
finger.status = otr.getStatus(otr.getTrustLevel(context));
}
Copy link
Owner

@arlolra arlolra Mar 14, 2016

Let's make this test the same as above,

if (uiConv) {
  let context = otr.getContext(uiConv.target);
  finger.status = otr.getStatus(otr.getTrustLevel(context));
}

Copy link
Collaborator Author

@vqhuy vqhuy Mar 14, 2016

@arlolra fixed.

offer all methods for verifying and update status after verification
335a493
@arlolra
Copy link
Owner

@arlolra arlolra commented Mar 14, 2016

Thanks!

Merged in 42cbf4e

@arlolra arlolra closed this Mar 14, 2016
@vqhuy vqhuy deleted the verifying-fingerprints branch Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment