Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate keys after account creation. #72

Closed
wants to merge 1 commit into from
Closed

Generate keys after account creation. #72

wants to merge 1 commit into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
ux
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@vqhuy @arlolra
@vqhuy
Copy link
Collaborator

@vqhuy vqhuy commented Mar 14, 2016

arlolra
arlolra reviewed Mar 14, 2016
View changes
chrome/content/ui.js
account: acc.normalizedName,
protocol: acc.protocol.normalizedName,
};
ui.generate(args);
Copy link
Owner

@arlolra arlolra Mar 14, 2016

ui.generate() is going to open a blocking modal, which is what we want to avoid.

Instead, you should directly call,

otr.generatePrivateKey(acc.normalizedName, acc.protocol.normalizedName)

which will launch the async worker.

We'll want to suppress any error here though. So,

otr.generatePrivateKey( ... ).catch(function(err) {
  Cu.reportError(err);
});

Generate keys after account creation.
49d7365 
* Part of #20
@arlolra
Copy link
Owner

@arlolra arlolra commented Mar 14, 2016

Great, thanks!

Merged in 67ffdb8

@arlolra arlolra closed this Mar 14, 2016
@vqhuy vqhuy deleted the key-generation branch Mar 15, 2016
@arlolra arlolra added the ux label Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment