handle already defined crypto object in webworker

[sualko]

With the latest version of Chrome (43.0.2357.124 (64-bit)) I get an error in line 7 for dsa-webworker.js:

Uncaught TypeError: Cannot set property crypto of #<WorkerGlobalScope> which has only a getter

Console.log for root.crypto prints:

Crypto {}
  subtle: SubtleCrypto

Patch tested in Chrome 43, Chromium 41.0.2272.76 and Firefox 38.0.

[arlolra]

Thanks for pointing this is out!

Console.log there is only enumerating the own properties but getRandomValues is available on the prototype chain, so we should use that where possible.

How does this look to you? f52a756

[sualko]

but getRandomValues is available on the prototype chain

You are right, I overlooked that and therefore your implementation is far better. 👍

[arlolra]

Ok, great. Merged. I'll try and cut a release soon.

[sualko]

I am not sure, why this did not pop up in my tests, but we have an error. We have to import does scripts, even if we have a crypto function available.

if (data.imports) imports = data.imports
importScripts.apply(root, imports);

if (!hasCrypto) {
      // use salsa20 when there's no prng in webworkers
      var state = new root.Salsa20(data.seed.slice(0, 32), data.seed.slice(32))
      root.crypto.randomBytes = function (n) {
        return state.getBytes(n)
      }
    }

Should I create a new pr?

[arlolra]

@sualko Thanks for catching that. I pushed a fix.