Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup build scripts #23

Merged
merged 3 commits into from Jun 3, 2019
Merged

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented May 31, 2019

Description

It was found that the build scripts were not properly failing in Travis CI.

Added bash flags to abort a build if an error is encountered, and added a trap to print where the error occurs.

Both build.sh and build-deps.sh have had https://github.com/koalaman/shellcheck run against them, and warnings fixed.

A missing license was added to build-deps.sh.

Notes

Cruz Monrreal II added 3 commits May 31, 2019 20:51
@cmonr
Copy link
Contributor Author

cmonr commented May 31, 2019

An example of what a build failure looks like with the new trap function:

./build.sh:60: 'go build "${GOTAGS}" "$@" github.com/armPelionEdge/maestro/maestro' failed with '1'

Copy link
Contributor

@SenRamakri SenRamakri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cmonr cmonr merged commit ad1612b into PelionIoT:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants