-
Notifications
You must be signed in to change notification settings - Fork 134
/
job_context.go
312 lines (273 loc) · 8.3 KB
/
job_context.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
package job
import (
"context"
"fmt"
"sync"
"time"
log "github.com/sirupsen/logrus"
v1 "k8s.io/api/core/v1"
"k8s.io/client-go/tools/cache"
executorContext "github.com/armadaproject/armada/internal/executor/context"
"github.com/armadaproject/armada/internal/executor/podchecks"
"github.com/armadaproject/armada/internal/executor/util"
"github.com/armadaproject/armada/pkg/api"
)
type IssueType int
const (
UnableToSchedule IssueType = iota
StuckStartingUp IssueType = iota
StuckTerminating IssueType = iota
ExternallyDeleted IssueType = iota
)
type RunningJob struct {
JobId string
ActivePods []*v1.Pod
Issue *PodIssue
}
type PodIssue struct {
OriginatingPod *v1.Pod
Pods []*v1.Pod
Message string
Retryable bool
Reported bool
Type IssueType
Cause api.Cause
}
type jobRecord struct {
jobId string
issue *PodIssue
}
type JobContext interface {
GetJobs() ([]*RunningJob, error)
MarkIssueReported(issue *PodIssue)
MarkIssuesResolved(job *RunningJob)
DeleteJobWithCondition(job *RunningJob, condition func(pod *v1.Pod) bool) error
DeleteJobs(jobs []*RunningJob)
AddAnnotation(jobs []*RunningJob, annotations map[string]string)
}
type ClusterJobContext struct {
clusterContext executorContext.ClusterContext
stuckTerminatingPodExpiry time.Duration
pendingPodChecker podchecks.PodChecker
updateThreadCount int
activeJobs map[string]*jobRecord
activeJobIdsMutex sync.Mutex
}
func NewClusterJobContext(
clusterContext executorContext.ClusterContext,
pendingPodChecker podchecks.PodChecker,
stuckTerminatingPodExpiry time.Duration,
updateThreadCount int,
) *ClusterJobContext {
jobContext := &ClusterJobContext{
clusterContext: clusterContext,
stuckTerminatingPodExpiry: stuckTerminatingPodExpiry,
pendingPodChecker: pendingPodChecker,
updateThreadCount: updateThreadCount,
activeJobs: map[string]*jobRecord{},
activeJobIdsMutex: sync.Mutex{},
}
clusterContext.AddPodEventHandler(cache.ResourceEventHandlerFuncs{
DeleteFunc: func(obj interface{}) {
pod, ok := obj.(*v1.Pod)
if !ok {
log.Errorf("Failed to process pod event due to it being an unexpected type. Failed to process %+v", obj)
return
}
if !util.IsLegacyManagedPod(pod) {
return
}
jobContext.handleDeletedPod(pod)
},
})
return jobContext
}
func (c *ClusterJobContext) GetJobs() ([]*RunningJob, error) {
pods, err := c.clusterContext.GetActiveBatchPods()
if err != nil {
return nil, err
}
pods = util.FilterPods(pods, util.IsLegacyManagedPod)
runningJobs := groupRunningJobs(pods)
return c.addIssues(runningJobs), nil
}
func (c *ClusterJobContext) MarkIssuesResolved(job *RunningJob) {
c.activeJobIdsMutex.Lock()
defer c.activeJobIdsMutex.Unlock()
record, exists := c.activeJobs[job.JobId]
if exists {
record.issue = nil
}
}
func (c *ClusterJobContext) MarkIssueReported(issue *PodIssue) {
issue.Reported = true
}
func (c *ClusterJobContext) DeleteJobWithCondition(job *RunningJob, condition func(pod *v1.Pod) bool) error {
for _, pod := range job.ActivePods {
err := c.clusterContext.DeletePodWithCondition(pod, condition, true)
if err != nil {
return err
}
}
return nil
}
func (c *ClusterJobContext) DeleteJobs(jobs []*RunningJob) {
c.activeJobIdsMutex.Lock()
defer c.activeJobIdsMutex.Unlock()
for _, job := range jobs {
c.clusterContext.DeletePods(job.ActivePods)
}
}
func (c *ClusterJobContext) AddAnnotation(jobs []*RunningJob, annotations map[string]string) {
podsToAnnotate := []*v1.Pod{}
for _, job := range jobs {
for _, pod := range job.ActivePods {
podsToAnnotate = append(podsToAnnotate, pod)
}
}
util.ProcessItemsWithThreadPool(context.Background(), c.updateThreadCount, podsToAnnotate,
func(pod *v1.Pod) {
err := c.clusterContext.AddAnnotation(pod, annotations)
if err != nil {
log.Warnf("Failed to annotate pod %s (%s) as done: %v", pod.Name, pod.Namespace, err)
}
},
)
}
func groupRunningJobs(pods []*v1.Pod) []*RunningJob {
podsByJobId := map[string][]*v1.Pod{}
for _, pod := range pods {
jobId := util.ExtractJobId(pod)
podsByJobId[jobId] = append(podsByJobId[jobId], pod)
}
result := []*RunningJob{}
for jobId, pods := range podsByJobId {
result = append(result, &RunningJob{
JobId: jobId,
ActivePods: pods,
})
}
return result
}
func (c *ClusterJobContext) registerIssue(jobId string, issue *PodIssue) {
record, exists := c.activeJobs[jobId]
if !exists {
record = &jobRecord{
jobId: jobId,
}
c.activeJobs[jobId] = record
}
if record.issue == nil {
record.issue = issue
} else {
log.Warnf("Not registering an issue for job %s as it already has an issue set", jobId)
}
}
func (c *ClusterJobContext) addIssues(jobs []*RunningJob) []*RunningJob {
c.activeJobIdsMutex.Lock()
defer c.activeJobIdsMutex.Unlock()
// register new jobs
runningJobIds := map[string]*RunningJob{}
for _, job := range jobs {
runningJobIds[job.JobId] = job
record, exists := c.activeJobs[job.JobId]
if !exists {
record = &jobRecord{
jobId: job.JobId,
}
c.activeJobs[job.JobId] = record
}
if record.issue == nil {
c.detectStuckPods(job)
}
}
for jobId, record := range c.activeJobs {
runningJob, isRunning := runningJobIds[jobId]
if isRunning {
runningJob.Issue = record.issue
} else {
if record.issue != nil {
jobs = append(jobs, &RunningJob{
JobId: jobId,
ActivePods: nil,
Issue: record.issue,
})
} else {
delete(c.activeJobs, jobId)
}
}
}
return jobs
}
func (c *ClusterJobContext) detectStuckPods(runningJob *RunningJob) {
for _, pod := range runningJob.ActivePods {
if pod.DeletionTimestamp != nil && pod.DeletionTimestamp.Add(c.stuckTerminatingPodExpiry).Before(time.Now()) {
// pod is stuck in terminating phase, this sometimes happen on node failure
// it is safer to produce failed event than retrying as the job might have run already
issue := &PodIssue{
OriginatingPod: pod.DeepCopy(),
Pods: runningJob.ActivePods,
Message: "pod stuck in terminating phase, this might be due to platform problems",
Retryable: false,
Type: StuckTerminating,
}
runningJob.Issue = issue
c.registerIssue(runningJob.JobId, issue)
break
} else if pod.Status.Phase == v1.PodUnknown || pod.Status.Phase == v1.PodPending {
podEvents, err := c.clusterContext.GetPodEvents(pod)
if err != nil {
log.Errorf("Unable to get pod events for pod %s: %v", pod.Name, err)
}
lastStateChange, err := util.LastStatusChange(pod)
if err != nil {
log.Errorf("Unable to get lastStateChange for pod %s: %v", pod.Name, err)
continue
}
action, cause, podCheckMessage := c.pendingPodChecker.GetAction(pod, podEvents, time.Now().Sub(lastStateChange))
if action != podchecks.ActionWait {
retryable := action == podchecks.ActionRetry
message := createStuckPodMessage(retryable, podCheckMessage)
podIssueType := StuckStartingUp
if cause == podchecks.NoNodeAssigned {
podIssueType = UnableToSchedule
}
log.Warnf("Found issue with pod %s in namespace %s: %s", pod.Name, pod.Namespace, message)
issue := &PodIssue{
OriginatingPod: pod.DeepCopy(),
Pods: runningJob.ActivePods,
Message: message,
Retryable: retryable,
Type: podIssueType,
}
runningJob.Issue = issue
c.registerIssue(runningJob.JobId, issue)
break
}
}
}
}
func createStuckPodMessage(retryable bool, originalMessage string) string {
if retryable {
return fmt.Sprintf("Unable to schedule pod, Armada will return lease and retry.\n%s", originalMessage)
}
return fmt.Sprintf("Unable to schedule pod with unrecoverable problem, Armada will not retry.\n%s", originalMessage)
}
func (c *ClusterJobContext) handleDeletedPod(pod *v1.Pod) {
c.activeJobIdsMutex.Lock()
defer c.activeJobIdsMutex.Unlock()
jobId := util.ExtractJobId(pod)
if jobId != "" {
isUnexpectedDeletion := !util.IsMarkedForDeletion(pod) && !util.IsPodFinishedAndReported(pod)
if isUnexpectedDeletion {
c.registerIssue(jobId, &PodIssue{
OriginatingPod: pod,
Pods: []*v1.Pod{pod},
Message: "Pod of the active job was deleted.",
Retryable: false,
Reported: false,
Type: ExternallyDeleted,
})
}
}
}