Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add media kernel for arm64 #2971

Merged
merged 1 commit into from Jul 7, 2021
Merged

Conversation

@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jul 5, 2021

Is this too critical to merge with rockchip64 ?

@150balbes
Copy link
Contributor Author

@150balbes 150balbes commented Jul 6, 2021

The set of patches and the core config for rockchip64 is focused on server-side options and is poorly suited for media. I specifically added a separate option that is focused on media and desktops. There are a lot of changes in it that are needed for media functions that do not matter for servers. It will also allow to smoothly (without destroying the current state of the core for rockchip64) switch to a common core for arm64 for those models that will be carefully checked and receive confirmation (perhaps for some will need much refinement with the addition of the necessary patches).

@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jul 6, 2021

switch to a common core for arm64 for those models

Understand. Since we don't have that common kernel yet, this one (also EDGE variant) could already be started / named as arm64 family?

@150balbes
Copy link
Contributor Author

@150balbes 150balbes commented Jul 6, 2021

I think it doesn't matter what name to use. If you use the "pure" name arm64, this is very similar to the prefix of the entire arm64 group and can create problems when used. You can use, for example, the "media" option or something else, at the discretion of other developers.

@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jul 6, 2021

Setting proper naming now matters for upgrade. IMO media is too specific, perhaps armbian64 ? Let's wait a day for people to comment.

@150balbes
Copy link
Contributor Author

@150balbes 150balbes commented Jul 6, 2021

I agree to any name, it doesn't matter to me. :)

I will offer several options for discussing mini \ standard (for the server) maxi \ full (for DE),

@150balbes
Copy link
Contributor Author

@150balbes 150balbes commented Jul 6, 2021

Additionally, I suggest discussing the transition to using a single DEB package for the kernel and DTB (to abandon a separate DEB package for DTB files). I have been using this option for many years on all devices and it works perfectly. Now it's easy to implement for the edge core, Here are the minimum changes for this (I can send a PR). It is important that in this variant the DTB files are placed together with the kernel , this ensures the correct operation of the system with any variant of the /boot partition placement (for example, with an encrypted rootfs system, when placing systems on different devices, downloading over the network, etc.). DTB is an integral element of the system startup, i.e. it is the most important part of the kernel and it should be together with the kernel files in one place.

Switching to this option from the current one (two packages) is painless, the system automatically switches to the new option when updating.

https://github.com/150balbes/build/tree/armbian-tv/packages/armbian

@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jul 6, 2021

I suggest discussing the transition to using a single DEB package for the kernel and DTB

Discussion yes, but I would not like to change anything big before releasing 2012.08 and having some vacations first ;) I understand it's not a big deal, but upgrade is critical and has to be well prepared and tested, also armbian-config routines, which are used for system testings. We also have exotics kernels, where some special attention might be needed. So, its some work.

@150balbes
Copy link
Contributor Author

@150balbes 150balbes commented Jul 6, 2021

This change applies only to the EDGE core, which is unstable in itself and is of a test nature specifically for debugging new functions. And its build works exactly with the new version of the package build settings (without specific patches using two pre-installed builddeb mkdeb files)). I agree that this change can be made after the release of 21.08. p. s. I do not insist, I only propose to discuss. :)

@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jul 6, 2021

This change applies only to the EDGE core

OK, that's only problematic for kernel switching in armbian-config. Open a Jira task for next release.

@150balbes
Copy link
Contributor Author

@150balbes 150balbes commented Jul 6, 2021

done

@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jul 7, 2021

OK, lets move this in as is and proceed to merging at some other occasion.

@igorpecovnik igorpecovnik merged commit 6bd67e1 into armbian:master Jul 7, 2021
2 checks passed
2 checks passed
@github-actions
shellcheck
Details
@github-actions
Compile changed kernel
Details
@150balbes 150balbes deleted the 150balbes:station-media branch Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants