Skip to content

Conversation

@rpardini
Copy link
Member

@rpardini rpardini commented May 8, 2023

by popular demand: bring back KERNEL_CONFIGURE=yes during image build

It seems I was once again terribly wrong. People love KERNEL_CONFIGURE=yes and specially the ability to select in dialog, and specially the one-step config+build all at once. Sorry for inconvenience caused...

  • partially revert 6ef394d (thus bring back the TUI/dialog for selecting KERNEL_CONFIGURE=yes/no)
  • partially revert d890b41 (thus bring back the capacity to config & build image in one go)
  • stop after configuring kernel, but only if command is kernel-config, not regular image-build KERNEL_CONFIGURE=yes

- partially revert 6ef394d (thus bring back the TUI/dialog for selecting KERNEL_CONFIGURE=yes/no)
- partially revert d890b41 (thus bring back the capacity to config & build image in one go)
- stop after configuring kernel, but only if command is `kernel-config`, not regular image-build KERNEL_CONFIGURE=yes
@rpardini rpardini added the Bugfix Pull request is fixing a bug label May 8, 2023
@rpardini rpardini requested a review from EvilOlaf May 8, 2023 09:08
@rpardini rpardini requested a review from a team as a code owner May 8, 2023 09:08
@rpardini rpardini requested a review from SteeManMI May 8, 2023 09:10
@rpardini
Copy link
Member Author

rpardini commented May 8, 2023

Let me ping @SteeManMI again here, since this is possibly the 3rd time I'm changing this. Terribly sorry...

Copy link
Contributor

@iav iav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as promised

@EvilOlaf
Copy link
Member

EvilOlaf commented May 8, 2023

If I use both KERNEL_CONIGURE=yes and kernel command it runs into KERNEL_CONFIGURE=yes is not supported anymore.

@rpardini
Copy link
Member Author

rpardini commented May 8, 2023

If I use both KERNEL_CONIGURE=yes and kernel command it runs into KERNEL_CONFIGURE=yes is not supported anymore.

Hmm. Yeah, this PR (up until now) only unlocks KERNEL_CONFIGURE=yes during image build, not during artifact/kernel build. Also, keep in mind that kernel will not prompt you via dialog for values (all has to be supplied via cmdline or config-file).

How important is this combo? It can be achieved, but is contrived.

@EvilOlaf
Copy link
Member

EvilOlaf commented May 8, 2023

Well the old way (and IMHO ideal since well established an known) has been to use KERNEL_CONFIGURED=yes KERNEL_ONLY=yes to build uboot/kernel debs with allowing user kernel configuration.
KERNEL_CONFIGURE=yes kernel would work too of course but why re-inventing the wheel?

@rpardini
Copy link
Member Author

rpardini commented May 8, 2023

KERNEL_ONLY=yes

This is 100% out of the picture and I don't think it is coming back (at least no by my hand, if I wanna keep any semblance of sanity). KERNEL_ONLY=yes back in old master meant "only packages", and not really "only kernel", and was interweaved in a lot of bad ways. Sorry.

KERNEL_CONFIGURE=yes kernel

That's doable, I'll send a separate PR.

@SteeManMI
Copy link
Contributor

@rpardini I'm not going to have time to look at this now, I think there are enough other eyes providing input however.

@rpardini rpardini merged commit e49d91e into armbian:main May 9, 2023
@rpardini rpardini deleted the pr/bring-back-KERNEL_CONFIGURE-during-image-build branch May 9, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Pull request is fixing a bug

Development

Successfully merging this pull request may close these issues.

4 participants