Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing and more pythonic things #11

Merged
merged 3 commits into from
Dec 30, 2020
Merged

Testing and more pythonic things #11

merged 3 commits into from
Dec 30, 2020

Conversation

yaleman
Copy link
Contributor

@yaleman yaleman commented Dec 29, 2020

While trying to reproduce the proxy issue I reported in #2 I ... added some stuff to help future maintenance (I hope?)

  • more error checking
  • some basic functionality testing
  • config loading's done in the Mirror class so you can pass config around easier
  • removed globals because... globals.

@yaleman yaleman mentioned this pull request Dec 29, 2020
@lanefu lanefu self-assigned this Dec 30, 2020
@lanefu
Copy link
Member

lanefu commented Dec 30, 2020

@yaleman this is awesome. thanks so much

@lanefu lanefu merged commit 2643439 into armbian:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants