-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abcl/1.7.0/rc/0 #223
Closed
Closed
Abcl/1.7.0/rc/0 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N.b. this patch provides Java implementation classes but does not wire their use into the VM. Add directAllocation() to nio BasicVector_ types, BasicVector_IntBuffer, BasicVector_CharBuffer, and BasicVector_IntBuffer are basically finished. TODO Finish adding direct allocation to nio derived types. Added implement a non-destructive version of shrink() to nio BasicVector types. TODO Finish adding directAllocation constructor to nio based (unsigned-byte 16) and (unsigned-byte 32) subclasses. Test. Audit. As the Hammer said to the Bear, "don't truss it".
BasicVector_ByteBuffer, BasicVector_CharBuffer, BasicVector_IntBuffer, ComplexVector_ByteBuffer, ComplexArray_ByteBuffer, SimpleArray_ByteBuffer, and SimpleArray_CharBuffer are now wired into the Cl:MAKE-ARRAY allocation strategy. Use Java.Buffers.AllocationStrategy enum to conditionalize use of either arrays of primitive type or java.nio.Buffer creation strategy for vector types. While eventually this might be able to be changed at runtime, currently this is a compile-time option hardwired to use the NIO allocation strategy.
Look ma, no new symbols! Well, if keywords aren't symbols. We augement CL:MAKE-ARRAY to add the keyword arguments :NIO-BUFFER and :NIO-DIRECT.
Use "abcl/nio-20200602a". <https://github.com/armedbear/cffi/tree/abcl/easye-20200602a>. Possibly pull and update repository to remote state.
Binaries available as https://abcl.org/releases/1.7.0/ |
Closed
Congrats on the milestone! |
Merged
superseded by #224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First release candidate for abcl-1.7.0