New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define undefined conditions #61

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@alanruttenberg
Collaborator

alanruttenberg commented Jul 12, 2017

on malformed destructuring-bind, bogus-sublist-error was being signaled, said condition didn't exist, and so true error was masked.

On review this code seems to be adapted from CMUCL, but special casing error-fun = 'error and using program-error instead of the conditions.

I brought over the conditions from CMUCL, which are in a comment at the bottom - they should loaded only after clos - wasn't sure of the mechanics.

I then defined a function for bogus-sublist error, based on the reports for the condition, and replaced arg-count-error with the more detailed report as well.

easye pushed a commit that referenced this pull request Aug 2, 2017

mevenson@1c010e3e-69d0-11dd-93a8-456734b0d56f
Define undefined conditions and handler functions following error-fun…
…='error pattern

(Alan Ruttenberg)

Activation of function are in in comments for now, pending solving boot issues.


On malformed destructuring-bind, bogus-sublist-error was being
signaled, but said condition didn't exist, and so true error was
masked.

On review this code seems to be adapted from CMUCL, but special casing
error-fun = 'error and using program-error instead of the conditions.

I brought over the conditions from CMUCL, which are in a comment at
the bottom - they should loaded only after clos - wasn't sure of the
mechanics.

I then defined a function for bogus-sublist error, based on the
reports for the condition, and replaced arg-count-error with the more
detailed report as well.

Merges <#61>.

From
<bdf75f5>,
<78c7e0e>.
@easye

This comment has been minimized.

Show comment
Hide comment
@easye

easye Aug 2, 2017

Collaborator

Merged with 38884a0.

Collaborator

easye commented Aug 2, 2017

Merged with 38884a0.

@easye easye closed this Aug 2, 2017

svn2github pushed a commit to svn2github/abcl that referenced this pull request Sep 6, 2017

mevenson
Define undefined conditions and handler functions following error-fun…
…='error pattern

(Alan Ruttenberg)

Activation of function are in in comments for now, pending solving boot issues.


On malformed destructuring-bind, bogus-sublist-error was being
signaled, but said condition didn't exist, and so true error was
masked.

On review this code seems to be adapted from CMUCL, but special casing
error-fun = 'error and using program-error instead of the conditions.

I brought over the conditions from CMUCL, which are in a comment at
the bottom - they should loaded only after clos - wasn't sure of the
mechanics.

I then defined a function for bogus-sublist error, based on the
reports for the condition, and replaced arg-count-error with the more
detailed report as well.

Merges <armedbear/abcl#61>.

From
<armedbear/abcl@bdf75f5>,
<armedbear/abcl@78c7e0e>.

git-svn-id: http://abcl.org/svn@15095 1c010e3e-69d0-11dd-93a8-456734b0d56f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment