Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a rotation node-socket #2305

Merged
merged 6 commits into from
Aug 26, 2021
Merged

Conversation

niacdoial
Copy link
Contributor

@niacdoial niacdoial commented Aug 19, 2021

consequences:

  • revamped all nodes that work with rotations
  • removed the notion of a quaternion socket (even though it was a vector socket by lender standards, which made it especially awkward)
  • rotation is now internally represented as a quaternion, not a XZY-ordered euler, which allows better performance in almost all cases

Some checking was done, both for haxe-time bugs, and for node-upgrade-time bugs. Hopefully this testing was complete.

NOTE: this pull request requires changes in iron, in the form of one file added under path iron/Sources/iron/math/Rotation.hx. The file is (hopefully) attached below. -> EDIT: now, the changes in iron are the patch to Quat.hx described at iron/pull/135

…th node

(part 1: conversion code not developed)
(and fixed a couple bugs along the way)
Also fixed a ton of bugs in the python part.
NOTE: this requires a yet-to-be-done commit to Iron to work.
(and homogeneised the contents of said branch in the process)
(plus a couple bugfixes, because what else)
@niacdoial
Copy link
Contributor Author

niacdoial commented Aug 19, 2021

here: Rotation.hx.gz
[outdated]

- fixed type/import bugs in RotationNode.hx and SeparateRotationNode.hx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants