Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix realtime postprocess & cleanup arm.lib.make_datas #2332

Merged
merged 2 commits into from Sep 12, 2021

Conversation

MoritzBrueckner
Copy link
Collaborator

Fixes #2323. This issue happened because PPCompXX uniforms were used in shaders which were not part of the compositor pass, however they were only correctly considered in that pass. Because the uniforms don't interfere with any non-compositor uniforms, it is safe to simply allow them for non-compositor shader passes.

I also cleaned up make_datas.py a bit, the changes are mostly semi-automatic IDE stuff, some type hints and comments and two big duplicate code blocks were moved into a function.

@MoritzBrueckner MoritzBrueckner added the Release Notes: Fixes A pull request that fixes something. Used to generate release notes. label Sep 7, 2021
@tong
Copy link
Contributor

tong commented Sep 9, 2021

Works for me.

@luboslenco luboslenco merged commit 5b4d24f into armory3d:master Sep 12, 2021
@MoritzBrueckner MoritzBrueckner deleted the fix-realtime-postprocess branch September 12, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes: Fixes A pull request that fixes something. Used to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Realtime postprocess not working
3 participants