Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove haxe --times param per default #2338

Merged
merged 2 commits into from Sep 22, 2021

Conversation

tong
Copy link
Contributor

@tong tong commented Sep 15, 2021

How about removing this flag per default ?
There isn't that much useful information in there and one could add it manually to the khafile.js if necessary.

@MoritzBrueckner
Copy link
Collaborator

What about adding it back as an option in the Armory developer settings? I guess it could be helpful to debug macro times, especially if the new assert macro should get used more.

@MoritzBrueckner MoritzBrueckner added the Release Notes: Changes A pull request that is a feature change, not a fix. Used to generate release notes. label Sep 15, 2021
@tong
Copy link
Contributor Author

tong commented Sep 15, 2021

Sounds good too. @luboslenco opinions ?

@luboslenco
Copy link
Member

Sounds good as an option in developer settings.

@tong
Copy link
Contributor Author

tong commented Sep 21, 2021

Added.
armsdk change is here: armory3d/armsdk#35

@luboslenco luboslenco merged commit 62d399e into armory3d:master Sep 22, 2021
@tong tong deleted the no-haxe-times-param branch September 23, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes: Changes A pull request that is a feature change, not a fix. Used to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants