Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exporting textures from linked libraries #2367

Merged
merged 1 commit into from Nov 1, 2021

Conversation

MoritzBrueckner
Copy link
Collaborator

Fixes an issue that could happen if a material from a linked library used a texture with a path relative to the library. In this case the relative path would be copied to the khafile and Iron would then try to load a nonexisting texture.

@luboslenco Currently krom_load_image() will return null when an image doesn't exist which will result in a Kha image object which neither has a texture_ nor a renderTarget_ set. Because of that, Amorcore will crash as soon as Iron tries to generate mipmaps for the image. Should there be handling for this in the mipmap generating function? Should krom_load_image() instead trigger a failure callback so that those failures can be more easily handled in Iron? I'm not sure what the "design philosophy" of Armorcore or Iron is in this case.

@MoritzBrueckner MoritzBrueckner added the Release Notes: Fixes A pull request that fixes something. Used to generate release notes. label Oct 25, 2021
@luboslenco luboslenco merged commit 9094154 into armory3d:master Nov 1, 2021
@luboslenco
Copy link
Member

Thanks! At https://github.com/Kode/Kha/blob/master/Backends/Krom/kha/LoaderImpl.hx#L14 loadImageFromDescription should call failed instead of done in that case, which could be enough to at least prevent the crash for now?

@MoritzBrueckner MoritzBrueckner deleted the fix-library-textures branch November 2, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes: Fixes A pull request that fixes something. Used to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants