Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix morph target exporting on Unix-based systems #2382

Merged
merged 1 commit into from Nov 8, 2021

Conversation

Skehmatics
Copy link
Contributor

@Skehmatics Skehmatics commented Nov 7, 2021

The new morph-target exporting had explicit backwards-slash directory separators, and while that works fine on Windows, we need to use forward-slash separators for the Unix-based systems (Linux, MacOS). I also received an issue due to some parameters not being ints in the NLA code, not sure if this is platform dependent or not.

To fix this, this PR uses os.path.join to automatically join the two with the correct separators as well as casts the problem paramaters to int. This also cleans up some extra spaces lying around in the file since my editor automatically removes them.

(Also, a million thanks to @QuantumCoderQC for this feature!!)

Also fixes some extra space issues since my editor auto-fixed them
@MoritzBrueckner MoritzBrueckner added the Release Notes: Fixes A pull request that fixes something. Used to generate release notes. label Nov 7, 2021
@luboslenco luboslenco merged commit 946610c into armory3d:master Nov 8, 2021
@luboslenco
Copy link
Member

Thanks!

@Skehmatics Skehmatics deleted the fix/morph_targets_linux branch November 8, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes: Fixes A pull request that fixes something. Used to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants