Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment gamma and improve handling of envmap file formats #2385

Merged
merged 3 commits into from
Nov 17, 2021

Conversation

MoritzBrueckner
Copy link
Collaborator

  • This PR tries to fix the overly strong irradiance brightness that was introduced by using a world render as the input to cmft. The biggest problem was that the environment render wasn't properly gamma corrected/in the wrong color space and thus too bright.

    Unfortunately there are still some visible differences to Blender depending on the situation, even though they are much less extreme now. Apparently cmft's calculations differ from Blender's calculations, when comparing the output of cmft for a given (color-correct) render of a plain color in this SH viewer with Blender there are still slight differences (without any tonemapping/color grading active).

    For more details please see https://forums.armory3d.org/t/render-too-bright/4666.

  • If there is a Enviroment Texture or a Image Texture node with sRGB color space, there is now gamma correction when calculating the SH coeffs.

  • Some minor handling improvements of envmap file formats

@MoritzBrueckner MoritzBrueckner added the Release Notes: Fixes A pull request that fixes something. Used to generate release notes. label Nov 15, 2021
@luboslenco luboslenco merged commit ea33a97 into armory3d:master Nov 17, 2021
@MoritzBrueckner MoritzBrueckner deleted the fix-environment-gamma branch November 17, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes: Fixes A pull request that fixes something. Used to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants