Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare node: fix accessing vector methods when DCE is on #2398

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

MoritzBrueckner
Copy link
Collaborator

Fixes https://forums.armory3d.org/t/removing-object-causes-game-to-freeze-only-after-exporting/4742.

Because the objects that are compared by the compare node are typed as Dynamic, DCE seems to have some problems and accidentally removes some used vector functions. To not clutter Iron code with @:keep metadata that makes it difficult to see why it was used in the first place, I decided to use the type check syntax instead to take away some work from the compiler.

@MoritzBrueckner MoritzBrueckner added the Release Notes: Fixes A pull request that fixes something. Used to generate release notes. label Nov 24, 2021
@luboslenco luboslenco merged commit 6a180a3 into armory3d:master Nov 26, 2021
@MoritzBrueckner MoritzBrueckner deleted the fix-dce-compare-node branch November 26, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes: Fixes A pull request that fixes something. Used to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants