Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve node library handling #2410

Merged
merged 3 commits into from
Dec 27, 2021

Conversation

MoritzBrueckner
Copy link
Collaborator

  • External node libraries can now use Armory's init_nodes() function that registers all nodes inside of a given package (recursively)
  • If node categories had special characters in their name (e.g. spaces), the menu class name and bl_idname would also contain those characters which would lead to warnings (interestingly, there was no error when using spaces before, just a warning...?)
  • Also fixed a small typo that is unrelated to this PR, but I didn't want to annoy you with a separate PR for this. @luboslenco it seems that I have write access to this repo, I guess it's ok for you if I would commit such trivial typo fixes directly to master? For everything else I will of course open a PR, but I think stuff like this is just unnecessary work for you.

@MoritzBrueckner MoritzBrueckner added the Release Notes: Changes A pull request that is a feature change, not a fix. Used to generate release notes. label Dec 23, 2021
@luboslenco luboslenco merged commit 7a05fb0 into armory3d:master Dec 27, 2021
@luboslenco
Copy link
Member

I guess it's ok for you if I would commit such trivial typo fixes directly to master?

Perfectly ok. 🙂

@MoritzBrueckner MoritzBrueckner deleted the node-library-improvements branch December 27, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes: Changes A pull request that is a feature change, not a fix. Used to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants