Fix and improve loading of libraries #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue described in https://forums.armory3d.org/t/celshade-option-only-appears-after-opening-forest-example-with-right-click-how-to-set-manually-for-other-blends/4891. Libraries weren't reloaded when changing files from within the same project, but registered render path drivers are removed each time a file is changed. Now libraries are reloaded each time a file is opened or the addon is reloaded, which also gives libraries the possibility to re-initialize itself for a new file. Also, libraries can now have an optional `unregister` function that will be called before a new file is loaded or when the addon is unregistered, giving libraries the possibility to properly clean up. Furthermore libraries no longer aren't loaded twice when a blend file is opened from the file explorer and there is a little debug message in the console that shows which libraries get (un-)loaded.
MoritzBrueckner
added
the
Release Notes: Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue described in https://forums.armory3d.org/t/celshade-option-only-appears-after-opening-forest-example-with-right-click-how-to-set-manually-for-other-blends/4891.
Libraries weren't reloaded when changing files from within the same project, but registered render path drivers are removed each time a file is changed. Now libraries are reloaded each time a file is opened or the addon is reloaded, which also gives libraries the possibility to re-initialize themselves for a new file. Also, libraries can now have an optional
unregisterfunction that will be called before a new file is loaded or when the addon is unregistered, giving libraries the possibility to properly clean up.Furthermore libraries are no longer loaded twice when a blend file is opened from the file explorer and there is a little debug message in the console that shows which libraries get (un-)loaded.