Tree variables: fix missing synchronization when adding getters/setters #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes armory3d#2504. Adding getters/setters for tree variables did not synchronize the variable values from the master node to all replica nodes, and because only the first logic node for a given variable is exported in place for all other nodes of the same variable, there was a race condition depending on which node was exported first. Files saved before the next SDK 22.09 will be automatically fixed upon loading.
MoritzBrueckner
added
the
Release Notes: Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2504.
Adding getters/setters for tree variables did not synchronize the variable values from the master node to all replica nodes, and because only the first logic node for a given variable is exported in place for all other nodes of the same variable, there was a race condition depending on which node was exported first. Files saved before the next SDK 22.09 will be automatically fixed upon loading.