Fix rigid body angular/ rolling friction #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse python dict to haxe typedef
MoritzBrueckner
added
the
Release Notes: Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with rolling friction in Rigid Bodies. Requires armory3d/iron#170
To fix the issue #831, angular damping was used instead of angular friction. But this caused additional issues with rolling objects such as spheres and cylinders. The actual issue was that linear friction setting was also used for angular friction, since there was no option in Blender rigid body settings. This PR adds a field for angular friction setting in the Rigid Body settings and uses it instead.
Additionally, the Rigid Body trait parameters is also changed form
Array<Float>andArray<Bool>totypedefas this offers more information about the values.