Disp color mix #2620
Merged
Disp color mix #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luboslenco
reviewed
Oct 4, 2022
blender/arm/material/make_tess.py
Outdated
| @@ -24,6 +24,7 @@ def interpolate(tese, var, size, normalize=False, declare_out=False): | |||
|
|
|||
| if normalize: | |||
| s += '{0}{1} = normalize({1}_0 + {1}_1 + {1}_2);\n'.format(prep, var) | |||
| s += 'vec3 n = normalize({0});\n'.format(var) | |||
There was a problem hiding this comment.
Well no, but in this case n is useless and should be replaced with wposition.
vec3 TextureCoordinate_Normal_res = n;
Problem is I don't see where this line comes from.
There was a problem hiding this comment.
The value of TextureCoordinate_Normal_res is probably generated in nodes_input.parse_texcoord() (called from within cycles.parse_vector()), and the name is generated here.
MoritzBrueckner
added
the
Release Notes: Fixes
|
I wanted to avoid creating the variable n and instead pass wnormal to the input normal from parse_texcoord, but this requires checking if we are using tessellation, and also verifying that we only do so for the tessellation shaders. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2618, without the changes for #2616.