Let's make the BxDFs more consistent! #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baked with matching shadowing and fresnel term used in Armory3D
It's done for consistency and correctness. Althrough, uncorrelated smith approx isn't super accurate.
I forgot that NdotL cancels out, and G2 goes negative under certain conditions
|
More stuff coming soon |
|
Thanks a lot! |
|
There's a typo line 265 in deferred_light.frag: envl is writen env1 |
|
Fixed in 1f6c14a, I don't think it needs an extra PR :) |
MoritzBrueckner
added
the
Release Notes: Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small batch of BxDF fixes for Armory, to make shading a bit more consistent with Eevee render.