Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking integration :) #2658

Merged
merged 59 commits into from
Nov 15, 2022
Merged

Networking integration :) #2658

merged 59 commits into from
Nov 15, 2022

Conversation

Onek8
Copy link
Contributor

@Onek8 Onek8 commented Nov 11, 2022

computer-reaction
** hxWebSocket maintained by @ianharrigan and other contributors is included in /Sources/armory/network with my addition of the wrapper Connect.hx file as well as a difference within one of the files regarding threads which are licensed according to the authors. My additional contribution can be CCZero cc0 public domain / MIT / ZLIB. For now I will remove the files from the library that are not used (java socket for example) and someone can change the contribution to the respective authors
**unless the hxWebSocket is added as a submodule instead of a maintained smaller copy

@Armory-Community-Channel

The networking video that will be made public when networking nodes are merged. Video here

@luboslenco
Copy link
Member

Super cool! Can you also place the hxwebsockets license alongside /Sources/armory/network?

@rpaladin
Copy link
Contributor

License has been added and verified with the original hxWebSocket creator @ ianharrigan.

image

@Onek8
Copy link
Contributor Author

Onek8 commented Nov 14, 2022

Sorry taken from the link https://lib.haxe.org/p/hxWebSockets/

@luboslenco luboslenco merged commit 0ca08dc into armory3d:main Nov 15, 2022
@luboslenco
Copy link
Member

Thanks!

@MoritzBrueckner MoritzBrueckner added the Release Notes: Changes A pull request that is a feature change, not a fix. Used to generate release notes. label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Notes: Changes A pull request that is a feature change, not a fix. Used to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants